Skip to content

[1.x] refactor(core): make search debounce time extensible #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Jan 28, 2025

1.x equivalent to #4172

Fixes #0000
Third-party extensions might want to adjust the search debounce time. Currently, it's very hard to customize this value.

Changes proposed in this pull request:
Create a new constant SEARCH_DEBOUNCE_TIME_MS for the search debounce timeout. Allows to third-party extensions to easily customize this value.

Reviewers should focus on:
Behaviour is the same as previously

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review January 28, 2025 08:04
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner January 28, 2025 08:04
@imorland imorland added this to the 1.8.10 milestone Feb 10, 2025
@imorland imorland merged commit 991a243 into flarum:1.x Feb 10, 2025
322 checks passed
@imorland imorland deleted the di/search-debounce-extensibility branch February 10, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants