[chore] ignore absent chart file #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipaqsa
force-pushed
the
chore/chart-file-absent
branch
2 times, most recently
from
8ac5b20 to
027c2d2
Compare
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
ipaqsa
force-pushed
the
chore/chart-file-absent
branch
from
027c2d2 to
4eb4a8f
Compare
ipaqsa
added
go
This was referenced Oct 10, 2025
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
ldmonster
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If chart file is absent, addon tries to create a Chart.yaml for a helm module, but it will fail on read only fs.
What this PR does / why we need it
If a module does not have Chart.yaml, we make it 'virtual'.
WARNING:
IT IS NOT THE BEST SOLUTION, BUT IT SEEMS ENOUGH FOR NOW