Fix interface IP address lookup in dual-stack mode #2283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, interface address lookup was performed only if both IPv4 and IPv6 addresses were undetermined. This change ensures that the address lookup occurs independently for each IP protocol.
rbrtbnfgl
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, interface address lookup was performed only if both IPv4 and IPv6 addresses were not known, which is an impossible scenario when an interface is selected based on IP address.
For example,
--iface 127.0.0.1would result inlointerface selected with IPv4 known and set to127.0.0.1, but it'd never have triggered IPv6 address lookup because of the wrong prerequisite of having to have both IPv4 and IPv6 set tonil.This change ensures that the address lookup occurs independently for each IP protocol.
Todos
Release Note