Fix: recreate VXLAN device (flannel.*) when external interface is deleted and re-added #2272
+258
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikjagrut
force-pushed
the
issue-2247
branch
from
042f323 to
dfe83f1
Compare
pratikjagrut
force-pushed
the
issue-2247
branch
from
dfe83f1 to
ec06b76
Compare
rbrtbnfgl
reviewed
Aug 27, 2025
pkg/backend/vxlan/vxlan_network.go
Outdated
| continue | ||
| } | ||
|
|
||
| ifaceAddrsV6, err := ip.GetInterfaceIP6Addrs(extIface) |
There was a problem hiding this comment.
I think here it could be an issue in case of IPv4 only setup. Also for IPv4 in case of IPv6 only setup.
There was a problem hiding this comment.
I updated the code PTAL.
There was a problem hiding this comment.
Probably better to use config.EnableIPv4 and config.EnableIPv6 to check if it's configured and then check the IP and don't create the interface in case of error.
There was a problem hiding this comment.
Updated. PTAL.
pratikjagrut
force-pushed
the
issue-2247
branch
from
ec06b76 to
c76e75b
Compare
…eted and re-added (flannel-io#2247) - Detects loss and reappearance of the external interface used by flannel - Recreates the dependent VXLAN device to restore network connectivity Signed-off-by: Pratik Jagrut <pratik.jagrut@suse.com>
pratikjagrut
force-pushed
the
issue-2247
branch
from
c76e75b to
6507b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the VXLAN backend where the
flannel.<vni>interface was not reliably re-created when the external network interface was deleted and re-added.Changes in this PR
This is a bug fix PR for issue
flannel.1interface disappears when--flannel-ifaceis recreated #2247This PR adds a watcher to monitor for missing VXLAN devices and trigger automatic re-creation once the external interface is available again.
Manual testing:
flannel.<vni>exists and pods can communicate.Affected component: VXLAN backend (network and device setup).
Todos
Release Not"