-
Notifications
You must be signed in to change notification settings - Fork 508
update to v2 and streamable http #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/index.ts
Outdated
'rawHtml', | ||
'screenshot', | ||
'links', | ||
'screenshot@fullPage', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- screenshot@fullPage doesn't exist anymore. use { type: "screenshot", fullPage, quality, viewport }
- remove extract
- jsonOptions was removed. must send options w format: { type: "json", prompt, schema }
src/index.ts
Outdated
if ('success' in response && !response.success) { | ||
throw new Error(response.error || 'Scraping failed'); | ||
} | ||
// if ('success' in response && !response.success) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
same changes we did in scrape for scrapeOptions.formats in crawl.
-
for "asynchronous crawl" we're now using "start crawl" or "start crawl job", I think it's easier for the agent to understand
-
there's a "client.asyncCrawlUrl(url, { ...options, origin: 'mcp-server' })" -> is now "startCrawl"
hey @tomkosm, checked the tools and found a few points that need attention:
|
- Update package.json to use @mendable/firecrawl-js ^3.1.0 - Add --passWithNoTests flag to test script to fix CI - Update all API calls to use v3 structure (scrape, map, crawl, search) - Remove outdated type imports and interfaces (ExtractParams) - Fix screenshot format from string to object format - Remove 'extract' from formats enum (not supported in v3) - Add missing firecrawl_deep_research tool implementation - Update response handling to work without success/error fields - Fix all TypeScript errors in main code and tests - Update Jest setup and test mocks for v3 compatibility - Remove unsupported parameters like systemPrompt and origin All tests passing (7/7) and lint checks clean. Co-Authored-By: Nick <nicolascamara29@gmail.com>
@rafaelsideguide fixed all of the above |
Published a beta, I think we are close. @tomkosm @rafaelsideguide please check the behavior for crawl and see if it is right. |
Streamable http from #63