Skip to content

Conversation

tomkosm
Copy link
Collaborator

@tomkosm tomkosm commented Aug 19, 2025

Streamable http from #63

src/index.ts Outdated
'rawHtml',
'screenshot',
'links',
'screenshot@fullPage',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • screenshot@fullPage doesn't exist anymore. use { type: "screenshot", fullPage, quality, viewport }
  • remove extract
  • jsonOptions was removed. must send options w format: { type: "json", prompt, schema }

src/index.ts Outdated
if ('success' in response && !response.success) {
throw new Error(response.error || 'Scraping failed');
}
// if ('success' in response && !response.success) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just remove this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • same changes we did in scrape for scrapeOptions.formats in crawl.

  • for "asynchronous crawl" we're now using "start crawl" or "start crawl job", I think it's easier for the agent to understand

  • there's a "client.asyncCrawlUrl(url, { ...options, origin: 'mcp-server' })" -> is now "startCrawl"

@rafaelsideguide
Copy link
Contributor

hey @tomkosm, checked the tools and found a few points that need attention:

  • map response is "[object Object]..." Screenshot 2025-08-22 at 08 47 52

  • add "prompt" param to crawl example

  • I had the mcp on cursor trying to search for local files multiple times. Can we improve the description to make sure that doesn't happen?

  • search needs [ "web" ] as default sources (and explain the option in the function description), otherwise will throw empty response.

  • extract doesnt have systemPrompt in v2

  • firecrawl_deep_research throws error "Unknown tool: firecrawl_deep_research"

  • generate_llmstxt doesnt exist on v2 anymore: "client.generateLLMsText is not a function"

  • firecrawl_scrape only works for markdown format, is that the expected bahavior? If you try to run firecrawl_scrape with formats: ["summary"] it returns "No content available". Maybe add firecrawl_scrape_summary tool?

devin-ai-integration bot added a commit that referenced this pull request Aug 23, 2025
- Update package.json to use @mendable/firecrawl-js ^3.1.0
- Add --passWithNoTests flag to test script to fix CI
- Update all API calls to use v3 structure (scrape, map, crawl, search)
- Remove outdated type imports and interfaces (ExtractParams)
- Fix screenshot format from string to object format
- Remove 'extract' from formats enum (not supported in v3)
- Add missing firecrawl_deep_research tool implementation
- Update response handling to work without success/error fields
- Fix all TypeScript errors in main code and tests
- Update Jest setup and test mocks for v3 compatibility
- Remove unsupported parameters like systemPrompt and origin

All tests passing (7/7) and lint checks clean.

Co-Authored-By: Nick <nicolascamara29@gmail.com>
@nickscamara
Copy link
Member

@rafaelsideguide fixed all of the above

@nickscamara
Copy link
Member

nickscamara commented Aug 23, 2025

Published a beta, I think we are close.

@tomkosm @rafaelsideguide please check the behavior for crawl and see if it is right.

@nickscamara nickscamara self-requested a review August 23, 2025 19:07
@nickscamara nickscamara merged commit 5d035e9 into main Aug 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants