fix(test): add sleep to wait for socat spinup in test_tap_offload #5228
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5228 +/- ##
==========================================
+ Coverage 82.89% 82.94% +0.05%
==========================================
Files 250 250
Lines 26965 26965
==========================================
+ Hits 22353 22367 +14
+ Misses 4612 4598 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
approved these changes
May 28, 2025
argh, forgot vim only breaks on whitespaces when reflowing. Wish there was a way to let the linter know that I'm copy pasting command stderr and would like to not be subject to the line lengths 😭 |
We are seeing an intermittent failure of the form FAILED test_net.py::test_tap_offload - ChildProcessError: [17861] Command:['ssh', ..., 'sync; cat /tmp/out.txt'] [17861] stdout: [17861] stderr: cat: /tmp/out.txt: No such file or directory It seems this is due to not waiting long enough for socat to spin up, so add a quick sleep which makes the issue disappear. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
It's a bit shorter. Stumbled across this randomly in the socat man page. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Microvms that have a network interface added to it will automatically
use ssh to wait for bootup, so use this to replace the 500ms sleep that
was not enough in some cases, leading to RuntimeError: ('Balloon config
error: Error creating the balloon device: Device not activated yet.',
{'fault_message': 'Balloon config error: Error creating the balloon
device: Device not activated yet.'}, <Response [400]>) errors on the
subsequent PATCH.
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added
the
Status: Awaiting review
zulinx86
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing an intermittent failure of the form
We theorize this is due to not waiting long enough for socat to spin up,
so add a quick sleep, which seems to fix the issue.
Signed-off-by: Patrick Roy roypat@amazon.co.uk## Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.We are seeing an intermittent failure of the form
FAILED
integration_tests/functional/test_net.py::test_tap_offload[uvm_restored-vmlinux-5.10.236]
[17861] Command:
['ip', 'netns', 'exec', 'netns-gw1-1', 'ssh', '-o',
'ControlPath=/srv/jailer/firecracker/4b087ca9-b1ec-4bf8-9dfd-2d6dcc378b9e/root/ssh-0.sock',
'root@192.168.0.2', 'sync; cat /tmp/out.txt']
[17861] stdout:
[17861] stderr:
cat: /tmp/out.txt: No such file or directory
We theorize this is due to not waiting long enough for socat to spin up,
so add a quick sleep.
Signed-off-by: Patrick Roy roypat@amazon.co.uk