fix: handle more edge cases in evaluateRuleIf #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANGkeith
commented
Sep 13, 2024
| let value = `${expandWith.variable(name)}`; | ||
| if (value.startsWith("\"/") && value.endsWith("/\"")) { | ||
| value = value.substring(1).slice(0, -1); | ||
| } |
There was a problem hiding this comment.
Removed this chunk in order to support the following scenario:
job:
image: alpine
variables:
teststring: "/test/url"
pattern: /test//
script:
- echo works
rules:
- if: '$teststring =~ $pattern' # gcl works
- if: $teststring =~ /test// # gcl does not work but it's expected to work
ANGkeith
commented
Sep 13, 2024
| {if: "$VAR1 && (($VAR2 =~ /ci-skip-job-/ && $VAR2 =~ $VAR3) || ($VAR2 =~ /ci-skip-stage-/ && $VAR2 =~ $VAR3))", when: "manual"}, | ||
| ]; | ||
| variables = {VAR1: "val", VAR2: "ci-skip-job-", VAR3: "ci-skip-job-"}; | ||
| variables = {VAR1: "val", VAR2: "ci-skip-job-", VAR3: "/ci-skip-job-/"}; |
There was a problem hiding this comment.
rhs here should be a regex
ANGkeith
force-pushed
the
fix/#1335
branch
3 times, most recently
from
f98ab80 to
b3e19c2
Compare
ANGkeith
changed the title
|
|
@ANGkeith You want a new version now? |
sure thing. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1335
Might have made the regex now even more confusing 😅
but hopefully this will make the rules evaluation behavior closer to gitlab.com's one...