Skip to content

Add OR snippets #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add OR snippets #430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
183ce4d
Add OR snippets
morganchen12 Mar 3, 2023
3a2fc21
fix bad query
morganchen12 Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions firestore/app/src/main/java/com/google/example/firestore/DocSnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,4 +1335,92 @@ public void onComplete(@NonNull Task<AggregateQuerySnapshot> task) {
});
// [END count_aggregate_query]
}

public void orQuery() {
CollectionReference collection = db.collection("cities");
// [START or_queries]
Query query = collection.where(Filter.and(
Filter.greaterThan("name", "L"),
Filter.or(
Filter.equalTo("capital", true),
Filter.greaterThanOrEqualTo("population", 1000000)
)
));
// [END or_queries]
}

public void orQueryDisjunctions() {
CollectionReference collection = db.collection("cities");

// [START one_disjunction]
collection.whereEqualTo("a", 1);
// [END one_disjunction]

// [START two_disjunctions]
collection.where(Filter.or(
Filter.equalTo("a", 1),
Filter.equalTo("b", 2)
));
// [END two_disjunctions]

// [START four_disjunctions]
collection.where(Filter.or(
Filter.and(
Filter.equalTo("a", 1),
Filter.equalTo("c", 3)
),
Filter.and(
Filter.equalTo("a", 1),
Filter.equalTo("d", 4)
),
Filter.and(
Filter.equalTo("b", 2),
Filter.equalTo("c", 3)
),
Filter.and(
Filter.equalTo("b", 2),
Filter.equalTo("d", 4)
)
));
// [END four_disjunctions]

// [START four_disjunctions_compact]
collection.where(Filter.and(
Filter.or(
Filter.equalTo("a", 1),
Filter.equalTo("b", 2)
),
Filter.or(
Filter.equalTo("c", 3),
Filter.equalTo("d", 4)
)
));
// [END four_disjunctions_compact]

// [START 20_disjunctions]
collection.where(Filter.or(
Filter.inArray("a", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
Filter.inArray("b", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there's currently a bug in the backend which prevents this query from being served -- Even though it is a valid query (it's valid to have one IN operator per disjunction).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this to the snippet registry and then exclude it from devsite for now.

// [END 20_disjunctions]

// [START 10_disjunctions]
collection.where(Filter.and(
Filter.inArray("a", Arrays.asList(1, 2, 3, 4, 5)),
Filter.or(
Filter.equalTo("b", 2),
Filter.equalTo("c", 3)
)
));
// [END 10_disjunctions]
}

public void illegalDisjunctions() {
// [START 50_disjunctions]
collection.where(Filter.and(
Filter.inArray("a", Arrays.asList(1, 2, 3, 4, 5)),
Filter.inArray("b", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
));
// [END 50_disjunctions]
}
}
88 changes: 88 additions & 0 deletions firestore/app/src/main/java/com/google/example/firestore/kotlin/DocSnippets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,4 +1107,92 @@ abstract class DocSnippets(val db: FirebaseFirestore) {
}
// [END count_aggregate_query]
}

fun orQuery() {
val collection = db.collection("cities")
// [START or_query]
val query = collection.where(Filter.and(
Filter.greaterThan("name", "L"),
Filter.or(
Filter.equalTo("capital", true),
Filter.greaterThanOrEqualTo("population", 1000000)
))
// [END or_query]
}

fun orQueryDisjunctions() {
val collection = db.collection("cities")

// [START one_disjunction]
collection.whereEqualTo("a", 1)
// [END one_disjunction]

// [START two_disjunctions]
collection.where(Filter.or(
Filter.equalTo("a", 1),
Filter.equalTo("b", 2)
))
// [END two_disjunctions]

// [START four_disjunctions]
collection.where(Filter.or(
Filter.and(
Filter.equalTo("a", 1),
Filter.equalTo("c", 3)
),
Filter.and(
Filter.equalTo("a", 1),
Filter.equalTo("d", 4)
),
Filter.and(
Filter.equalTo("b", 2),
Filter.equalTo("c", 3)
),
Filter.and(
Filter.equalTo("b", 2),
Filter.equalTo("d", 4)
)
))
// [END four_disjunctions]

// [START four_disjunctions_compact]
collection.where(Filter.and(
Filter.or(
Filter.equalTo("a", 1),
Filter.equalTo("b", 2)
),
Filter.or(
Filter.equalTo("c", 3),
Filter.equalTo("d", 4)
)
))
// [END four_disjunctions_compact]

// [START 20_disjunctions]
collection.where(Filter.or(
Filter.inArray("a", [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),
Filter.inArray("b", [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),
))
// [END 20_disjunctions]

// [START 10_disjunctions]
collection.where(Filter.and(
Filter.inArray("a", [1, 2, 3, 4, 5]),
Filter.or(
Filter.equalTo("b", 2),
Filter.equalTo("c", 3)
)
))
// [END 10_disjunctions]
}

fun illegalDisjunctions() {
val collection = db.collection("cities")
// [START 50_disjunctions]
collection.where(Filter.and(
Filter.inArray("a", [1, 2, 3, 4, 5]),
Filter.inArray("b", [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),
));
// [END 50_disjunctions]
}
}