add: fdc quickstart #802

HYACCCINT · 2024-05-30T21:33:01Z

No description provided.

github-actions · 2024-05-30T21:33:15Z

Doc Tag Diff

This PR makes the following changes to doc tags (0 added, 0 removed, 0 changed):

dataconnect/README.md

maneesht · 2024-06-04T17:41:15Z

dataconnect/dataconnect/connector/connector.yaml

+    # directory as your app code
+    outputDir: "../../movie/lib/dataconnect-sdk"
+    # This property tells Data Connect what directory to install the generated SDK to
+    # packageJsonDir: "../../movie/lib/dataconnect-sdk"


Should we un-comment this?

dataconnect/movie/components/navbar.tsx

dataconnect/dataconnect/schema/schema.gql

fredzqm · 2024-06-17T23:27:42Z

dataconnect/dataconnect/connector/connector.yaml

+connectorId: movie-connector
+# Required. Accepted values are either "PUBLIC" or "ADMIN" (only "PUBLIC" for gated private
+# preview). If "ADMIN", the connector in this directory is an AdminConnector and its operations
+# are gated by IAM.


Remove this comment about IAM mode. Will read super confusing to folks.

fredzqm · 2024-06-17T23:30:04Z

dataconnect/dataconnect/connector/mutations.gql

+# Delete movies with a rating lower than the specified minimum rating
+mutation deleteUnpopularMovies($minRating: Float!) {
+  movie_deleteMany(where: { rating: { le: $minRating } })
+}


GQL above don't have @auth.

They aren't accessible by SDK, so would recommend move them either to a separate Connector. Or a README.

Backend probably should reject UpdateConnector with operation with @auth or at least warn them.

fredzqm · 2024-06-17T23:31:42Z

dataconnect/dataconnect/connector/mutations.gql

+
+# Remove a movie from the user's watched list
+mutation deleteWatchedMovie($userId: String!, $movieId: UUID!) @auth(level: USER) {
+  watchedMovie_delete(key: { userId: $userId, movieId: $movieId })


Yeah, can you add a TODO to rewrite this once key support userId_expr?

Thanks a bunch. Missed this edge case when we implement server values.

There is a few similar cases below.

@HYACCCINT The next data connect release would support

watchedMovie_delete(key: { userId_expr: "auth.uid", movieId: $movieId })

Can you help update any @auth(level: USER) operations to use the secure server value instead of passing in $userId: String?

[I think searching for "$userId: String" should find all occurrences]

I prioritized this fix to avoid quick starting containing glaring security anti-practices.

dataconnect/dataconnect/connector/queries.gql

fredzqm · 2024-06-17T23:33:45Z

dataconnect/dataconnect/connector/queries.gql

+
+# Get favorite movies by user ID
+query GetFavoriteMoviesById($id: String!) @auth(level: USER) {
+  user(id: $id) {


Please use id_expr to make it secure.

It should work now.

Same for other lookup below.

Not done yet~ Though out this page. Security matters

Let me know $id here is supposed to match the Firebase Auth UID.

dataconnect/dataconnect/connector/queries.gql

charlotteliang · 2024-06-21T15:57:20Z

dataconnect/README.md

+
+This is a sample app for the preview version of the Firebase DataConnect.
+This will not work if you don't have access to the preview.
+


Sign up for early access here

charlotteliang · 2024-06-21T15:57:47Z

dataconnect/README.md

+
+1. Sign up for early access [here](https://firebase.google.com/products/data-connect) and receive an invitation.
+2. Upgrade your Firebase project billing to the Blaze plan, you will not be charged for the duration of gated preview.
+3. Initialize DataConnect in the [Firebase Console](https://console.firebase.google.com/u/0/).


Initialize Firebase Data Connect Service

charlotteliang · 2024-06-21T15:58:04Z

dataconnect/README.md

+1. Sign up for early access [here](https://firebase.google.com/products/data-connect) and receive an invitation.
+2. Upgrade your Firebase project billing to the Blaze plan, you will not be charged for the duration of gated preview.
+3. Initialize DataConnect in the [Firebase Console](https://console.firebase.google.com/u/0/).
+4. Clone this repository to your local machine.


can you add a clone cmd here

charlotteliang · 2024-06-21T15:59:23Z

dataconnect/README.md

+4. Clone this repository to your local machine.
+5. Update `firebase-tools` with `npm install -g firebase-tools`.
+6. Enable the DataConnect CLI with `firebase experiments:enable dataconnect`.
+7. Initialize your Firebase project in the `dataconnect` folder with `firebase init` and select DataConnect. Do not overwrite the dataconnect files when prompted.


Install VS Code

Download VS Code extension here

open the folder data connect with VS Code

charlotteliang · 2024-06-21T15:59:53Z

dataconnect/README.md

+6. Enable the DataConnect CLI with `firebase experiments:enable dataconnect`.
+7. Initialize your Firebase project in the `dataconnect` folder with `firebase init` and select DataConnect. Do not overwrite the dataconnect files when prompted.
+8. Replace variables in `.env.local` with your project-specific values.
+9. Allow domains for Firebase Auth (e.g., http://localhost or http://127.0.0.1).


move local dev below as an option: if you want to dev locally, here's the steps:

charlotteliang · 2024-06-21T16:00:07Z

dataconnect/README.md

+7. Initialize your Firebase project in the `dataconnect` folder with `firebase init` and select DataConnect. Do not overwrite the dataconnect files when prompted.
+8. Replace variables in `.env.local` with your project-specific values.
+9. Allow domains for Firebase Auth (e.g., http://localhost or http://127.0.0.1).
+10. Deploy DataConnect with `firebase deploy --only dataconnect` (this unlocks hidden vectors search).


Use vscode button click on Firebase deploy

charlotteliang · 2024-06-21T16:00:28Z

dataconnect/README.md

+8. Replace variables in `.env.local` with your project-specific values.
+9. Allow domains for Firebase Auth (e.g., http://localhost or http://127.0.0.1).
+10. Deploy DataConnect with `firebase deploy --only dataconnect` (this unlocks hidden vectors search).
+11. Start the DateConnect emulators.


I think the latest extension you no longer need this step. it's started by default now

charlotteliang · 2024-06-21T16:02:14Z

dataconnect/README.md

+11. Start the DateConnect emulators.
+12. Run `firebase dataconnect:sdk:generate` to generate the SDK
+13. Navigate to the `movie` directory and install dependencies with `npm i` and start the development server with `npm run dev`.
+14. Run the four `_insert.gql` files in the `./dataconnect` directory in order.


Are these steps needed?

Maybe show an example of how to run a query in graphQL, by clicking on the "run" button on the codelen
and then show the same code generated in the SDK and show how to call in the app.

Or just run the app.

fredzqm · 2024-07-02T17:55:55Z

dataconnect/dataconnect/connector/mutations.gql

+
+# Remove a movie from the user's watched list
+mutation deleteWatchedMovie($userId: String!, $movieId: UUID!) @auth(level: USER) {
+  watchedMovie_delete(key: { userId: $userId, movieId: $movieId })


@HYACCCINT The next data connect release would support

watchedMovie_delete(key: { userId_expr: "auth.uid", movieId: $movieId })

Can you help update any @auth(level: USER) operations to use the secure server value instead of passing in $userId: String?

[I think searching for "$userId: String" should find all occurrences]

I prioritized this fix to avoid quick starting containing glaring security anti-practices.

fredzqm · 2024-07-02T17:57:55Z

dataconnect/dataconnect/connector/queries.gql

+
+# List movies by the order of release
+query ListMoviesByReleaseYear @auth(level: PUBLIC) {
+  movies(orderBy: [{ releaseYear: DESC }]) {


style nit: GQL does list coercion, so orderBy: { releaseYear: DESC } behave the same as orderBy: [{ releaseYear: DESC }]

The singular syntax looks a bit nicer for just one order by.

fredzqm · 2024-07-02T18:00:19Z

dataconnect/dataconnect/connector/queries.gql

+}
+
+# User movie preferences
+query UserMoviePreferences($username: String!) @auth(level: USER) {


OOC, is this $username supposed to be the Firebase Auth user?

It's not secure here because auth.uid isn't used any where.

fredzqm · 2024-07-02T20:39:15Z

dataconnect/dataconnect/connector/queries.gql

+
+# Get favorite movies by user ID
+query GetFavoriteMoviesById($id: String!) @auth(level: USER) {
+  user(id: $id) {


Not done yet~ Though out this page. Security matters

Let me know $id here is supposed to match the Firebase Auth UID.

feat: fdc quickstart

427c4de

HYACCCINT added 2 commits May 31, 2024 14:48

fix: remove generated files

ce69548

fix: readme

6d3b882

HYACCCINT requested review from maneesht and yuchenshi June 3, 2024 14:49

HYACCCINT added 4 commits June 3, 2024 12:33

fix: vector search

1196349

fix: vector query description

bf92f74

fix: gitignore

0cc97fb

fix: lint

d3ffc0f

HYACCCINT requested a review from cherylEnkidu June 3, 2024 16:41

HYACCCINT added 2 commits June 3, 2024 13:30

fix: update embedding version

e840d97

fix: username

b396a6f

maneesht requested changes Jun 4, 2024

View reviewed changes

fredzqm requested changes Jun 17, 2024

View reviewed changes

charlotteliang reviewed Jun 21, 2024

View reviewed changes

charlotteliang approved these changes Jun 21, 2024

View reviewed changes

HYACCCINT added 2 commits June 25, 2024 20:39

feat: update versions

b066256

fix: signinwithredirect

0823b91

fredzqm reviewed Jul 2, 2024

View reviewed changes

HYACCCINT closed this Jul 25, 2024

HYACCCINT deleted the fdc-quickstart branch July 29, 2024 22:33


		This is a sample app for the preview version of the Firebase DataConnect.
		This will not work if you don't have access to the preview.

add: fdc quickstart #802

add: fdc quickstart #802

Uh oh!

Conversation

HYACCCINT commented May 30, 2024

Uh oh!

github-actions bot commented May 30, 2024

Doc Tag Diff

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fredzqm Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fredzqm Jun 17, 2024 •

edited

Loading