-
Notifications
You must be signed in to change notification settings - Fork 955
fix: Improve logging of errors in the browser if a circular reference or bigint is encountered #9181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ails in the browser.
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (638,603 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Drive-by comment: Are you able to add unit test coverage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to adding a unit test that invokes formatJSON
with object containing the two special cases. Looks good otherwise.
An alternative solution to get information for #8903.
As reported by the user in #8093,
err.name
anderr.message
wereundefined
after the fix of #8907 was applied. Based on the previous behavior it's likely that error was not actually an error object, but instead it was some object that was failing to stringify withJSON.stringify
. This solution reverts gettingerr.name
and instead attempts to work around possible JSON.stringify issues.