-
Notifications
You must be signed in to change notification settings - Fork 949
Maintain persistence for firebaseToken in AuthImpl object #9119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gcip-byociam-web
Are you sure you want to change the base?
Changes from all commits
23f46c1
4268eb0
51a90cf
e257fad
d008f14
5814784
1544a21
20401e8
b5796f0
fb88cd7
97752d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -280,6 +280,12 @@ export interface Auth { | |
callback: (user: User | null) => void | Promise<void>, | ||
onAbort?: () => void | ||
): Unsubscribe; | ||
|
||
onFirebaseTokenChanged( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. q: When do we call
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey, I
The callback method was initially not planned. I had a discussion with pavanshankar@ and we decided on decoupling the persistence logic with the callback method. Created a PR - #9138 for persisting the firebaseToken for BYO-CIAM. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Related: this method was not part of the API review. I'm concerned that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. Created a PR - #9138 for persisting the firebaseToken for BYO-CIAM. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should go through another API review process surfacing this. "firebaseToken" is a really generic name -- "Firebase" is a huge suite of products that has many different types of tokens. Any and every change to the public API surface needs to go through review |
||
nextOrObserver: NextOrObserver<FirebaseToken | null>, | ||
error?: ErrorFn, | ||
completed?: CompleteFn | ||
): Unsubscribe; | ||
/** | ||
* Adds an observer for changes to the signed-in user's ID token. | ||
* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to do same for signOut as well right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I plan to create a separate CL for signOut logic. Please let me know if you see any concerns.