Skip to content

Implement exchangeToken public api #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 23, 2025
Merged

Implement exchangeToken public api #9039

merged 11 commits into from
May 23, 2025

Conversation

mansisampat
Copy link
Contributor

Discussion

  • Implement the Public APIs for exchangeToken

Testing

  • Testing done via demo app
  • Implemented Unit test

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 14bb1cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@mansisampat mansisampat force-pushed the sammansi-gcip-byociam-web branch from 40ca4b5 to 27674f1 Compare May 14, 2025 12:51
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 14, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (a3dc91a)Merge (2bde55b)Diff
    browser195 kB195 kB-117 B (-0.1%)
    cordova168 kB168 kB-146 B (-0.1%)
    main149 kB150 kB+706 B (+0.5%)
    module195 kB195 kB-117 B (-0.1%)
    react-native167 kB168 kB+845 B (+0.5%)

  • @firebase/auth-cordova

    TypeBase (a3dc91a)Merge (2bde55b)Diff
    browser168 kB168 kB-146 B (-0.1%)
    module168 kB168 kB-146 B (-0.1%)

  • @firebase/auth-web-extension

    TypeBase (a3dc91a)Merge (2bde55b)Diff
    browser145 kB145 kB-119 B (-0.1%)
    main161 kB162 kB+1.30 kB (+0.8%)
    module145 kB145 kB-119 B (-0.1%)

  • @firebase/auth/internal

    TypeBase (a3dc91a)Merge (2bde55b)Diff
    browser206 kB206 kB-117 B (-0.1%)
    main175 kB176 kB+1.19 kB (+0.7%)
    module206 kB206 kB-117 B (-0.1%)

  • bundle

    TypeBase (a3dc91a)Merge (2bde55b)Diff
    auth (Anonymous)79.5 kB78.2 kB-1.25 kB (-1.6%)
    auth (EmailAndPassword)89.6 kB88.4 kB-1.23 kB (-1.4%)
    auth (GoogleFBTwitterGitHubPopup)111 kB110 kB-1.26 kB (-1.1%)
    auth (GooglePopup)104 kB102 kB-1.26 kB (-1.2%)
    auth (GoogleRedirect)104 kB102 kB-1.26 kB (-1.2%)
    auth (Phone)97.0 kB95.8 kB-1.21 kB (-1.2%)

  • firebase

    TypeBase (a3dc91a)Merge (2bde55b)Diff
    firebase-auth-compat.js147 kB146 kB-985 B (-0.7%)
    firebase-auth-cordova.js144 kB144 kB-6 B (-0.0%)
    firebase-auth-web-extension.js127 kB127 kB+35 B (+0.0%)
    firebase-auth.js164 kB164 kB+82 B (+0.0%)
    firebase-compat.js804 kB803 kB-1.01 kB (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XVtDZ3f0t3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 14, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (375,540 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yXY1K1ZIGH.html

@mansisampat mansisampat force-pushed the sammansi-gcip-byociam-web branch 2 times, most recently from fb70a71 to 41ad562 Compare May 19, 2025 06:08
NhienLam
NhienLam reviewed May 20, 2025
View reviewed changes
@NhienLam
Copy link
Contributor

Please resolve the merge conflicts.

@mansisampat mansisampat force-pushed the sammansi-gcip-byociam-web branch from d03fc34 to 978f78f Compare May 22, 2025 05:06
@mansisampat mansisampat requested a review from NhienLam May 22, 2025 05:16
pashanka
pashanka reviewed May 22, 2025
View reviewed changes
@mansisampat mansisampat requested a review from pashanka May 22, 2025 08:15
NhienLam
NhienLam approved these changes May 22, 2025
View reviewed changes
@mansisampat mansisampat merged commit ffec9ba into gcip-byociam-web May 23, 2025
45 of 46 checks passed
@mansisampat mansisampat deleted the sammansi-gcip-byociam-web branch May 23, 2025 06:18
mansisampat added a commit that referenced this pull request Jun 18, 2025
@mansisampat
Implement exchangeToken public api (#9039)
fce8bac 
* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)

* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)

* Implement exchangeToken public api

* Using expiry_in returned by backend

* Addressing review comments and adding some Unit test

* Docgen

* Addressing review comments and adding some Unit test

* Typo

* yarn docgen

* Fixing typo

* yarn run format
mansisampat added a commit that referenced this pull request Jun 18, 2025
@mansisampat
Implement exchangeToken public api (#9039)
fbb6ac9 
* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)

* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)

* Implement exchangeToken public api

* Using expiry_in returned by backend

* Addressing review comments and adding some Unit test

* Docgen

* Addressing review comments and adding some Unit test

* Typo

* yarn docgen

* Fixing typo

* yarn run format
@firebase firebase locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NhienLam NhienLam NhienLam approved these changes

@pashanka pashanka pashanka approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@visumickey visumickey Awaiting requested review from visumickey

@avolkovi avolkovi Awaiting requested review from avolkovi

@yoyomyo yoyomyo Awaiting requested review from yoyomyo

@zwu52 zwu52 Awaiting requested review from zwu52

@maneesht maneesht Awaiting requested review from maneesht

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mansisampat @google-oss-bot @NhienLam @pashanka