Skip to content

[Infra] Enable internal imports by default for SPM #15094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/AILog.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import Foundation
import os.log

internal import FirebaseCoreExtension
import FirebaseCoreExtension

enum AILog {
/// Log message codes for the Firebase AI SDK
Expand Down
5 changes: 2 additions & 3 deletions FirebaseAI/Sources/FirebaseAI.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@

import FirebaseAppCheckInterop
import FirebaseAuthInterop
import FirebaseCore
import FirebaseCoreExtension
import Foundation

// Avoids exposing internal FirebaseCore APIs to Swift users.
internal import FirebaseCoreExtension
public import FirebaseCore

/// The Firebase AI SDK provides access to Gemini models directly from your app.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/GenerateContentResponse.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

/// The model's response to a generate content request.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/GenerativeAIRequest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
protocol GenerativeAIRequest: Sendable, Encodable {
Expand Down
9 changes: 7 additions & 2 deletions FirebaseAI/Sources/PartsRepresentable+Image.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,16 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import CoreGraphics
import UniformTypeIdentifiers
#if canImport(UIKit)
import UIKit // For UIImage extensions.
public import UIKit // For UIImage extensions.
#elseif canImport(AppKit)
import AppKit // For NSImage extensions.
public import AppKit // For NSImage extensions.
#endif

#if canImport(CoreImage)
import CoreImage
#endif

private let imageCompressionQuality: CGFloat = 0.8
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

/// An error that occurs when image generation fails due to all generated images being blocked.
///
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

/// An image generated by Imagen, represented as inline data.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/Types/Public/Part.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

/// A discrete piece of data in a media format interpretable by an AI model.
///
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Tests/Unit/VertexComponentTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

@preconcurrency import FirebaseCore
internal import FirebaseCoreExtension
import FirebaseCoreExtension
import Foundation
import XCTest

Expand Down
2 changes: 1 addition & 1 deletion FirebaseAppDistributionInternal/Sources/ApiService.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import FirebaseInstallations
import Foundation
import UIKit

internal import FirebaseCoreInternal
import FirebaseCoreInternal

enum Strings {
static let errorDomain = "com.firebase.appdistribution.api"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import Foundation

internal import FirebaseCoreExtension
import FirebaseCoreExtension

///
/// Logger is responsible for printing console logs
Expand Down
12 changes: 6 additions & 6 deletions FirebaseAuth/Sources/Swift/Auth/Auth.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@
import Foundation

import FirebaseAppCheckInterop
import FirebaseAuthInterop
import FirebaseCore
public import FirebaseAuthInterop
public import FirebaseCore
import FirebaseCoreExtension
#if COCOAPODS
internal import GoogleUtilities
import GoogleUtilities
#else
internal import GoogleUtilities_AppDelegateSwizzler
internal import GoogleUtilities_Environment
import GoogleUtilities_AppDelegateSwizzler
import GoogleUtilities_Environment
#endif

#if os(iOS) || os(tvOS) || targetEnvironment(macCatalyst)
import UIKit
public import UIKit

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code

Check warning on line 29 in FirebaseAuth/Sources/Swift/Auth/Auth.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-15, Xcode_16.4, tvOS)

public import of 'UIKit' was not used in public declarations or inlinable code
#endif

// Export the deprecated Objective-C defined globals and typedefs.
Expand Down
4 changes: 2 additions & 2 deletions FirebaseAuth/Sources/Swift/MultiFactor/TOTP/TOTPSecret.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

import Foundation
#if COCOAPODS
internal import GoogleUtilities
import GoogleUtilities
#else
internal import GoogleUtilities_Environment
import GoogleUtilities_Environment
#endif

#if os(iOS)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
import UIKit

#if COCOAPODS
internal import GoogleUtilities
import GoogleUtilities
#else
internal import GoogleUtilities_Environment
import GoogleUtilities_Environment
#endif // COCOAPODS

// Protocol to help with unit tests.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
import Foundation
import UIKit
#if COCOAPODS
internal import GoogleUtilities
import GoogleUtilities
#else
internal import GoogleUtilities_Environment
import GoogleUtilities_Environment
#endif

/// Class responsible for providing a default AuthUIDelegate.
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Utilities/AuthUIDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#if os(iOS) || os(tvOS) || os(visionOS)

import Foundation
import UIKit
public import UIKit

/// A protocol to handle user interface interactions for Firebase Auth.
///
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#if DEBUG

import Foundation
public import Foundation

Check warning on line 17 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatLoggingTestUtils.swift

View workflow job for this annotation

GitHub Actions / tests (iOS, Xcode_16.2)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 17 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatLoggingTestUtils.swift

View workflow job for this annotation

GitHub Actions / mlmodeldownloader-sample-build-test

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 17 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatLoggingTestUtils.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-15)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 17 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatLoggingTestUtils.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-14)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 17 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatLoggingTestUtils.swift

View workflow job for this annotation

GitHub Actions / storage-combine-integration

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 17 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatLoggingTestUtils.swift

View workflow job for this annotation

GitHub Actions / xcodebuild (iOS)

public import of 'Foundation' was not used in public declarations or inlinable code

/// A utility class intended to be used only in testing contexts.
@objc(FIRHeartbeatLoggingTestUtils)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / tests (iOS, Xcode_16.2)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / mlmodeldownloader-sample-build-test

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-15)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-14)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / storage-combine-integration

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / xcodebuild (iOS)

public import of 'Foundation' was not used in public declarations or inlinable code

#if SWIFT_PACKAGE
internal import GoogleUtilities_NSData
import GoogleUtilities_NSData
#else
internal import GoogleUtilities
import GoogleUtilities
#endif // SWIFT_PACKAGE

/// A type that provides a string representation for use in an HTTP header.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift

View workflow job for this annotation

GitHub Actions / tests (iOS, Xcode_16.2)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift

View workflow job for this annotation

GitHub Actions / mlmodeldownloader-sample-build-test

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-15)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-14)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift

View workflow job for this annotation

GitHub Actions / storage-combine-integration

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatController.swift

View workflow job for this annotation

GitHub Actions / xcodebuild (iOS)

public import of 'Foundation' was not used in public declarations or inlinable code

/// An object that provides API to log and flush heartbeats from a synchronized storage container.
@objc(FIRHeartbeatController)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / tests (iOS, Xcode_16.2)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / mlmodeldownloader-sample-build-test

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-15)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / client-app-cocoapods (ClientApp-CocoaPods, macos-14)

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / storage-combine-integration

public import of 'Foundation' was not used in public declarations or inlinable code

Check warning on line 15 in FirebaseCore/Internal/Sources/HeartbeatLogging/_ObjC_HeartbeatsPayload.swift

View workflow job for this annotation

GitHub Actions / xcodebuild (iOS)

public import of 'Foundation' was not used in public declarations or inlinable code

/// A model object representing a payload of heartbeat data intended for sending in network
/// requests.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import Foundation
#if SWIFT_PACKAGE
@_exported import FirebaseDatabaseInternal
#endif // SWIFT_PACKAGE
import FirebaseSharedSwift
public import FirebaseSharedSwift

public extension DataSnapshot {
/// Retrieves the value of a snapshot and converts it to an instance of
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import Foundation
#if SWIFT_PACKAGE
@_exported import FirebaseDatabaseInternal
#endif // SWIFT_PACKAGE
import FirebaseSharedSwift
public import FirebaseSharedSwift

public extension DatabaseReference {
/// Encodes an instance of `Encodable` and overwrites the encoded data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#if SWIFT_PACKAGE
@_exported import FirebaseDatabaseInternal
#endif // SWIFT_PACKAGE
import FirebaseSharedSwift
public import FirebaseSharedSwift

public extension Database {
typealias Encoder = FirebaseDataEncoder
Expand Down
2 changes: 1 addition & 1 deletion FirebaseFunctions/Sources/Callable+Codable.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

@preconcurrency import FirebaseSharedSwift
import Foundation
public import Foundation

/// A `Callable` is a reference to a particular Callable HTTPS trigger in Cloud Functions.
///
Expand Down
6 changes: 3 additions & 3 deletions FirebaseFunctions/Sources/Functions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@

import FirebaseAppCheckInterop
import FirebaseAuthInterop
import FirebaseCore
public import FirebaseCore
import FirebaseMessagingInterop
import FirebaseSharedSwift
public import FirebaseSharedSwift
import Foundation
#if COCOAPODS
@preconcurrency import GTMSessionFetcher
#else
@preconcurrency import GTMSessionFetcherCore
#endif

internal import FirebaseCoreExtension
import FirebaseCoreExtension
private import FirebaseCoreInternal

/// File specific constants.
Expand Down
2 changes: 1 addition & 1 deletion FirebaseFunctions/Sources/HTTPSCallable.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

private import FirebaseCoreInternal

Expand Down
2 changes: 1 addition & 1 deletion FirebaseFunctions/Sources/HTTPSCallableOptions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import Foundation
public import Foundation

/// Configuration options for a ``HTTPSCallable`` instance.
@objc(FIRHTTPSCallableOptions) public final class HTTPSCallableOptions: NSObject, Sendable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import SwiftUI
public import SwiftUI

#if SWIFT_PACKAGE
@_exported import FirebaseInAppMessagingInternal
Expand Down Expand Up @@ -49,7 +49,7 @@
public extension View {
/// Overrides the default display of an image only in-app message as defined on the Firebase
/// console.
func imageOnlyInAppMessage<Content: View>(closure: @escaping (InAppMessagingImageOnlyDisplay,

Check failure on line 52 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type

Check failure on line 52 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type
InAppMessagingDisplayDelegate)
-> Content)
-> some View {
Expand Down Expand Up @@ -86,7 +86,7 @@
@available(tvOSApplicationExtension, unavailable)
public extension View {
/// Overrides the default display of a banner in-app message as defined on the Firebase console.
func bannerInAppMessage<Content: View>(closure: @escaping (InAppMessagingBannerDisplay,

Check failure on line 89 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type

Check failure on line 89 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type
InAppMessagingDisplayDelegate)
-> Content)
-> some View {
Expand Down Expand Up @@ -123,7 +123,7 @@
@available(tvOSApplicationExtension, unavailable)
public extension View {
/// Overrides the default display of a modal in-app message as defined on the Firebase console.
func modalInAppMessage<Content: View>(closure: @escaping (InAppMessagingModalDisplay,

Check failure on line 126 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type

Check failure on line 126 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type
InAppMessagingDisplayDelegate)
-> Content)
-> some View {
Expand Down Expand Up @@ -160,7 +160,7 @@
@available(tvOSApplicationExtension, unavailable)
public extension View {
/// Overrides the default display of a card in-app message as defined on the Firebase console.
func cardInAppMessage<Content: View>(closure: @escaping (InAppMessagingCardDisplay,

Check failure on line 163 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type

Check failure on line 163 in FirebaseInAppMessaging/Swift/Source/CustomInAppMessageDisplayViewModifier.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method must be declared internal because its parameter uses an internal type
InAppMessagingDisplayDelegate)
-> Content)
-> some View {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import UIKit
public import UIKit

Check warning on line 15 in FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift

View workflow job for this annotation

GitHub Actions / tests (iOS, Xcode_16.2)

public import of 'UIKit' was not used in public declarations or inlinable code

#if SWIFT_PACKAGE
@_exported import FirebaseInAppMessagingInternal
Expand All @@ -22,7 +22,7 @@
@available(iOSApplicationExtension, unavailable)
@available(tvOSApplicationExtension, unavailable)
public enum InAppMessagingPreviewHelpers {
public static func cardMessage(campaignName: String = "Card message campaign",

Check failure on line 25 in FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method cannot be declared public because its result uses an internal type
title: String = "Title for modal message",
body: String? = "Body for modal message",
textColor: UIColor = UIColor.label,
Expand Down Expand Up @@ -78,7 +78,7 @@
)
}

public static func modalMessage(campaignName: String = "Modal message campaign",

Check failure on line 81 in FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift

View workflow job for this annotation

GitHub Actions / spm / spm (macos-14, Xcode_16.2, iOS)

method cannot be declared public because its result uses an internal type
title: String = "Title for modal message",
body: String? = "Body for modal message",
textColor: UIColor = UIColor.black,
Expand Down
2 changes: 1 addition & 1 deletion FirebaseMLModelDownloader/Sources/DeviceLogger.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import Foundation

internal import FirebaseCoreExtension
import FirebaseCoreExtension

/// Enum of log messages.
enum LoggerMessageCode: Int {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

import Foundation
#if SWIFT_PACKAGE
internal import GoogleUtilities_UserDefaults
import GoogleUtilities_UserDefaults
#else
internal import GoogleUtilities
import GoogleUtilities
#endif // SWIFT_PACKAGE

/// Protocol to save or delete model info in user defaults.
Expand Down
4 changes: 2 additions & 2 deletions FirebaseMLModelDownloader/Sources/LocalModelInfo.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

import Foundation
#if SWIFT_PACKAGE
internal import GoogleUtilities_UserDefaults
import GoogleUtilities_UserDefaults
#else
internal import GoogleUtilities
import GoogleUtilities
#endif // SWIFT_PACKAGE

/// Model info object with details about downloaded and locally available model.
Expand Down
4 changes: 2 additions & 2 deletions FirebaseMLModelDownloader/Sources/ModelDownloadTask.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

import Foundation
#if SWIFT_PACKAGE
internal import GoogleUtilities_UserDefaults
import GoogleUtilities_UserDefaults
#else
internal import GoogleUtilities
import GoogleUtilities
#endif // SWIFT_PACKAGE

/// Task to download model file to device.
Expand Down
6 changes: 3 additions & 3 deletions FirebaseMLModelDownloader/Sources/ModelDownloader.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import FirebaseCore
public import FirebaseCore
import FirebaseInstallations
import Foundation
#if SWIFT_PACKAGE
internal import GoogleUtilities_UserDefaults
import GoogleUtilities_UserDefaults
#else
internal import GoogleUtilities
import GoogleUtilities
#endif // SWIFT_PACKAGE

/// Possible ways to get a custom model.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
@testable import FirebaseMLModelDownloader
import XCTest
#if SWIFT_PACKAGE
internal import GoogleUtilities_UserDefaults
import GoogleUtilities_UserDefaults
#else
internal import GoogleUtilities
import GoogleUtilities
#endif // SWIFT_PACKAGE

extension GULUserDefaults {
Expand Down
Loading
Loading