Skip to content

New and clearer FirebaseAnalytics subspecs #14882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2025
Merged

New and clearer FirebaseAnalytics subspecs #14882

merged 7 commits into from
May 22, 2025

Conversation

pcfba
Copy link
Contributor

@pcfba pcfba commented May 22, 2025

The new subspecs: Default, Core, and IdentitySupport.

The previous subspecs that are now deprecated: AdIdSupport (use IdentitySupport) and WithoutAdIdSupport (use Core).

#no-changelog

@pcfba pcfba added this to the 11.14.0 - M165 milestone May 22, 2025
@pcfba pcfba requested review from ncooke3 and tsunghung May 22, 2025 17:43
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3
Copy link
Member

ncooke3 commented May 22, 2025

Looks like linting is failing due to Analytics support macOS but GoogleAdsODC does not.

Copy link
Contributor

@tsunghung tsunghung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make GoogleAdsOnDeviceConversion an iOS-only dependency. Other than that, LGTM.

@pcfba
Copy link
Contributor Author

pcfba commented May 22, 2025

Thanks. I'm making the changes now.

…sionWrapper/ and FirebaseAnalyticsWithoutAdIdSupportWrapper/
@pcfba pcfba enabled auto-merge (squash) May 22, 2025 23:02
@pcfba pcfba merged commit 4f6c342 into main May 22, 2025
54 of 57 checks passed
@pcfba pcfba deleted the odm2-open-beta-2 branch May 22, 2025 23:25
@ncooke3
Copy link
Member

ncooke3 commented May 23, 2025

@pcfba, looks like there was a real SPM failure that'll need addressing:

Error: error: The package product 'GULLogger' requires minimum platform version 10.15 for the macOS platform, but this target supports 10.13 (in target 'GoogleAdsOnDeviceConversionTarget' from project 'GoogleAdsOnDeviceConversion')

I'll move tags and stage specs to get a jump on zip testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants