-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Infra] Common cocoapods pod lib lint job #14876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ncooke3
wants to merge
36
commits into
main
Choose a base branch
from
nc/ci-improve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5bfc8a6
[Infra] Common cocoapods pod lib lint job
ncooke3 e552608
tmp disable
ncooke3 a86fed3
fix debug approach
ncooke3 25183fd
fix?
ncooke3 8012322
debug
ncooke3 5ed9382
fix?
ncooke3 8ba29f0
fix?
ncooke3 eef376d
fix?
ncooke3 9555ece
i
ncooke3 b413c54
gotcha
ncooke3 5b98f52
more
ncooke3 8c8e3cb
t
ncooke3 6ec836c
t
ncooke3 6d6512e
try again
ncooke3 305ac97
more
ncooke3 3a89fde
more progress
ncooke3 c788326
remove trailing space
ncooke3 ca431c2
add warnings support
ncooke3 6b38aa2
functions and swift 6 support
ncooke3 265b4af
check
ncooke3 eeaf85c
fix cron dep
ncooke3 e9f3e54
more refactors
ncooke3 f724cda
remove blank space
ncooke3 35a5032
more
ncooke3 3896c01
more
ncooke3 9ec01fe
ss-permissions
ncooke3 fe6b030
more work:
ncooke3 609eb43
fixes
ncooke3 a9df005
Fix CI
ncooke3 139cc5f
whitespace
ncooke3 50731d5
App distro fix
ncooke3 8417b85
fix auth by setting env var in reusable workflow
ncooke3 051f40f
fix fiam with specific platforms
ncooke3 1d5a2aa
Fix messaging some
ncooke3 03f95b0
fix fdl, fai
ncooke3 da3b7d2
fixes and more migrations
ncooke3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
name: common_cocoapods | ||
|
||
permissions: | ||
contents: read | ||
|
||
on: | ||
workflow_call: | ||
inputs: | ||
# The product to test be tested (e.g. `FirebaseABTesting`). | ||
product: | ||
type: string | ||
required: true | ||
|
||
// # The platforms to build on. Defaults to all. | ||
// # To target specific platforms, pass a comma or space separated string of | ||
// # platforms. | ||
// # | ||
// # Examples: | ||
// # - build/test only for macOS: `macOS` | ||
// # - build/test only for macOS and tvOS: `macOS, tvOS` | ||
// platforms: | ||
// type: string | ||
// required: false | ||
// default: "iOS, tvOS, macOS, watchOS, catalyst, visionOS" | ||
|
||
// # By default, all platforms will be tested (see matrix in `spm` job). | ||
// # To build instead of test, pass a comma or space separated string of | ||
// # platforms. | ||
// # | ||
// # Platform options: [iOS, tvOS, macOS, watchOS, catalyst, visionOS] | ||
// # | ||
// # Note: Build-only platforms must be represented in the `platforms` input | ||
// # (which defaults to all platforms) in order to take effect. | ||
// # | ||
// # Examples: | ||
// # - build only for macOS: `macOS` | ||
// # - build only for macOS and tvOS: `macOS, tvOS` | ||
// # - build only for all platforms: `all` | ||
// buildonly_platforms: | ||
// type: string | ||
// required: false | ||
// default: "" | ||
|
||
jobs: | ||
pod-lib-lint: | ||
# Run on the main repo's scheduled jobs or pull requests and manual workflow invocations. | ||
if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name) | ||
strategy: | ||
matrix: | ||
os: macos-15 | ||
xcode: Xcode_16.3 | ||
platform: [iOS, tvOS, macOS, watchOS] | ||
include: | ||
- os: macos-14 | ||
xcode: Xcode_16.2 | ||
platform: iOS | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
- name: Setup Bundler | ||
run: scripts/setup_bundler.sh | ||
- name: Xcode | ||
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer | ||
- uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 | ||
if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' | ||
with: | ||
timeout_minutes: 120 | ||
max_attempts: 3 | ||
retry_on: error | ||
retry_wait_seconds: 120 | ||
command: scripts/pod_lib_lint.rb ${{ inputs.product }}.podspec --platforms=${{ matrix.platform }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.