Skip to content

[Firebase AI] Add Swift package product library FirebaseAI #14773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Apr 24, 2025

  • Added a new library for FirebaseAI to the public products in Package.swift.
  • Re-ordered Package.swift to put FirebaseAI in alphabetical order (FirebaseVertexAI kept nearby but will be removed in a breaking change).
  • Updated the integration test app to depend on the new library.
  • Renamed the internal static function firebaseAI to createInstance in FirebaseAI.
    • This was intended for the previous PR but missed it in my local client. This addresses the Gemini finding in [Firebase AI] Implement new public API surface and tests #14765:
      Naming Consistency: The naming of the internal initializer firebaseAI(app:location:apiConfig:) in FirebaseAI.swift is a bit confusing, as it shares the same name as the public API. Consider renaming the internal initializer to something more descriptive, like createFirebaseAIInstance.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@andrewheard andrewheard marked this pull request as ready for review April 24, 2025 23:31
@andrewheard
Copy link
Contributor Author

@paulb777 Any concerns with ignoring Firestore cmake?

@paulb777
Copy link
Member

paulb777 commented Apr 25, 2025 via email

@paulb777 paulb777 merged commit cc3e32e into firebase-ai Apr 25, 2025
67 of 73 checks passed
@paulb777 paulb777 deleted the ah/firebase-ai-product branch April 25, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants