Skip to content

RC Configure ephemeral URLSession for iOS 18.4 simulator #14768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2025

Conversation

tusharkhandelwal8
Copy link
Contributor

Resolved an issue where RCN Config fetch was failing earlier on iOS 18.4 simulators; this is now fixed. Addressed a bug in URLSession causing network requests to fail in the iOS 18.4 and visionOS 2.4 simulators (included with Xcode 16.3). The workaround implemented is to use an ephemeral URLSession configuration when running in these simulators. See https://developer.apple.com/forums/thread/777999 for more details. Behavior on older simulators and physical devices is unchanged.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@tusharkhandelwal8 tusharkhandelwal8 marked this pull request as ready for review April 24, 2025 17:29
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM with one nit.

@tusharkhandelwal8 tusharkhandelwal8 merged commit 1c16807 into main Apr 25, 2025
55 checks passed
@tusharkhandelwal8 tusharkhandelwal8 deleted the fetch-failure branch April 25, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants