Skip to content

[Infra] Disable flaky FIAM UI tests in Xcode 16 #14758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2025
Merged

[Infra] Disable flaky FIAM UI tests in Xcode 16 #14758

merged 6 commits into from
Apr 23, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 23, 2025

The UI animations of the FIAM UI elements appear to be slowing down the UI test tests.

Disabling. Tracking in #14760

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Apr 23, 2025
@paulb777
Copy link
Member

Thanks! Would you take a quick look at #12770 to see if it also resolves?

@paulb777
Copy link
Member

And an even quicker look at #8682?

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 23, 2025

@paulb777 , sure, but unfortunately this didn't fix CI. It had fixed it locally for me but not on here... https://github.com/firebase/firebase-ios-sdk/actions/runs/14620149571/job/41017804557?pr=14758

@ncooke3 ncooke3 changed the title [Infra] Reduce Xcode 16 UI test flakiness by disabling animations [Infra] Disable flaky FIAM UI tests in Xcode 16 Apr 23, 2025
@ncooke3 ncooke3 requested a review from paulb777 April 23, 2025 14:51
@ncooke3 ncooke3 merged commit ba460b0 into main Apr 23, 2025
50 checks passed
@ncooke3 ncooke3 deleted the nc/fiam-fix branch April 23, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants