Skip to content

[Infra] Create common SPM-focused reusable workflow #14739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 22, 2025
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 18, 2025

Create a re-usable workflow for our spm jobs. This helps consolidate our Xcode/macos testing strategy for our spm jobs.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3 ncooke3 marked this pull request as ready for review April 21, 2025 14:01
@ncooke3 ncooke3 changed the title [Infra] Create common SPM-focused reusable workflow [Infra] Create common SPM-focused reusable workflow (first pass) Apr 21, 2025
@ncooke3 ncooke3 changed the title [Infra] Create common SPM-focused reusable workflow (first pass) [Infra] Create common SPM-focused reusable workflow Apr 21, 2025
@ncooke3 ncooke3 marked this pull request as draft April 21, 2025 14:10
@ncooke3
Copy link
Member Author

ncooke3 commented Apr 22, 2025

Still debugging...

  • crashlytics / spm / spm (macos-15, Xcode_16.2, catalyst) (pull_request) Failing after 12m
    Details
  • inappmessaging / tests (iOS, Xcode_16.2) (pull_request) Failing after 294m
    Details

@ncooke3 ncooke3 requested review from paulb777 and andrewheard April 22, 2025 16:36
@ncooke3 ncooke3 marked this pull request as ready for review April 22, 2025 16:38
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks!

@ncooke3 ncooke3 merged commit feec4a0 into main Apr 22, 2025
419 of 422 checks passed
@ncooke3 ncooke3 deleted the nc/concise-ci branch April 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants