[v11] Remove configureWithApp: API in FIRLibrary protocol
#13147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3
commented
Jun 17, 2024
| if (_autoBootstrapOnFIRAppInit) { | ||
| FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM170002", | ||
| @"Auto bootstrap Firebase in-app messaging SDK"); | ||
| [FIRInAppMessaging bootstrapIAMFromFIRApp:container.app]; |
There was a problem hiding this comment.
This API was previously being called in configureWithApp:. Now, I'm proposing we move it into the creationBlock and set the timing instantiation to eager as the API's execution will have similar timing to being in configureWithApp:.
paulb777
reviewed
Jun 18, 2024
paulb777
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2933