-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[v11] Deprecate OAuthProvider API get credential API that uses string provider ID #13097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3
commented
Jun 14, 2024
ncooke3
commented
Jun 14, 2024
The "get credential" API are done. I was going to break up the migration into smaller PRs since the |
paulb777
approved these changes
Jun 14, 2024
ncooke3
commented
Jun 14, 2024
ncooke3
added a commit
that referenced
this pull request
Jun 14, 2024
pragatimodi
pushed a commit
that referenced
this pull request
Jun 17, 2024
pragatimodi
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process:
@available(swift, introduced: 100.0)
to make it ObjC-only and replaceString
types in ObjC-only API withNSString
. This has the following result:@available(swift, introduced: 100.0)
attribute, the@objc(...)
decorator, and swap theNSString
types forString
. This should leave the current Swift API. Mark it deprecated (see PR diff for example deprecation comment).providerID: String
forproviderID: AuthProviderID
No changes are needed to ObjC API tests:
firebase-ios-sdk/FirebaseAuth/Tests/Unit/ObjCAPITests.m
Lines 420 to 428 in 63070a4
Decisions: