Skip to content

[v11] Clean up deprecated app delegate methods #13073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2024
Merged

[v11] Clean up deprecated app delegate methods #13073

merged 2 commits into from
Jun 5, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 5, 2024

#no-changelog

@paulb777 paulb777 force-pushed the pb-app-delegate-cleanup branch from 95bc8eb to 90e2c60 Compare June 5, 2024 18:00
@paulb777 paulb777 requested review from andrewheard and ncooke3 June 5, 2024 18:41
ncooke3
ncooke3 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would have the effect of the SDK no longer working for clients who haven't moved away from the deprecated API, right?

@paulb777
Copy link
Member Author

paulb777 commented Jun 5, 2024

It would, but I would be surprised if the old APIs are still being used since they've been deprecated for awhile.

@paulb777 paulb777 merged commit 49764ab into release-11.0 Jun 5, 2024
59 checks passed
@paulb777 paulb777 deleted the pb-app-delegate-cleanup branch June 5, 2024 19:24
pragatimodi pushed a commit that referenced this pull request Jun 10, 2024
@paulb777 @pragatimodi
[v11] Clean up deprecated app delegate methods (#13073)
2ee630e
pragatimodi pushed a commit that referenced this pull request Jun 17, 2024
@paulb777 @pragatimodi
[v11] Clean up deprecated app delegate methods (#13073)
8aa388c
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulb777 @andrewheard @ncooke3 @google-oss-bot