Skip to content

[v11] Drop support for deprecated notification methods #13064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 4, 2024

In conjunction with Auth (#13003) and GoogleUtilities v9, drop support for (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo in favor of (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo fetchCompletionHandler:`

The PR also fixes decoder warnings that show up running the unit tests.

Fix #11693

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 requested review from andrewheard and ncooke3 June 4, 2024 21:39
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see a couple less deprecated blocks 👍

@paulb777 paulb777 merged commit 594abb8 into release-11.0 Jun 4, 2024
59 checks passed
@paulb777 paulb777 deleted the pb-fcm-notif branch June 4, 2024 21:58
@DemetAkyolKapar
Copy link

DemetAkyolKapar commented Jun 11, 2024

When I remove didReceiveRemoteNotification, which method will be used instead?
I am using 10.24.0 version sdk and the didReceiveRemoteNotification method is not called, what can I do?
{"message":{"notification":{"title":"Test","body":"Feed"},"data":{"message":"Feed"},"apns":{"headers":{"apns-priority":"10"},"payload":{"aps":{"badge":1,"collapse_key":"FCM_Sender","content_available":true,"time_to_live":90,"sound":"default"}}},"token":"c........"}}

@paulb777 @pragatimodi

@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants