[v11] Remove unused FIRDependency class #13053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures look similar to other release-11.0
|
ryanwilson
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Sort of a shame that it was never used (e.g. in the component creation blocks, SDKs could/should verify that any dependencies are there or throw an error early) but looks like FIAM is the only one with a hard dependency, and really the package managers take care of that. LGTM! Thanks for the cleanup.
pragatimodi
pushed a commit
that referenced
this pull request
Jun 10, 2024
pragatimodi
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog