Skip to content

Fix Auth Domain search code to match comment #13042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2024
Merged

Fix Auth Domain search code to match comment #13042

merged 2 commits into from
May 31, 2024

Conversation

paulb777
Copy link
Member

Fix #7992

@paulb777 paulb777 requested review from ncooke3 and Xiaoshouzi-gh May 30, 2024 23:59
ncooke3
ncooke3 approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! optional: Should a unit test be added to assert this behavior? And a changelog entry?

@paulb777
Copy link
Member Author

@ncooke3 Thanks for keeping me honest. I've updated the unit tests so it fails with the old code and passes with the new - and added a CHANGELOG update.

ncooke3
ncooke3 approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI failure looks GoogleUtilities related and can be ignored

@paulb777
Copy link
Member Author

Merging here. I'll address any additional comments in a later PR.

@paulb777 paulb777 merged commit 63bf8d3 into release-11.0 May 31, 2024
53 of 54 checks passed
@paulb777 paulb777 deleted the pb-inner-outer-flip branch May 31, 2024 16:53
pragatimodi pushed a commit that referenced this pull request Jun 10, 2024
@paulb777 @pragatimodi
Fix Auth Domain search code to match comment (#13042)
8af97bd
pragatimodi pushed a commit that referenced this pull request Jun 17, 2024
@paulb777 @pragatimodi
Fix Auth Domain search code to match comment (#13042)
c29c658
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @ncooke3 @google-oss-bot