Skip to content

Updated gtm session fetcher to allow for exponential backoff #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Feb 3, 2023

No description provided.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Storage is not using any new GTMSessionFetcher APIs, I'm not sure we should start requiring GTMSessionFetcher 3.1. Anyone who wants the new capability can already get it by updating and those that have other dependencies requiring earlier GTM versions won't be impacted.

@maneesht
Copy link
Contributor Author

maneesht commented Feb 3, 2023

@paulb777 - the main reason for the upgrade is to fix situations when exponential backoff is required. For example, if there's an issue with an intermediary Google Cloud service, without this fix, we will just keep hitting the server infinitely, draining resources on people's machines.

@maneesht
Copy link
Contributor Author

maneesht commented Feb 3, 2023

Context: google/gtm-session-fetcher#323

@paulb777
Copy link
Member

paulb777 commented Feb 4, 2023

There is nothing stopping developers from updating GTMSessonFetcher now to 3.1 if they can.

I'd prefer to avoid breaking interoperability with SDKs like ARCore until a major release, when we have a process to engage with other SDK teams on dependency changes.

@paulb777 paulb777 added this to the Firebase 11 milestone Feb 14, 2023
@paulb777
Copy link
Member

Marked for the next breaking change of Firebase 11 to update the minimum allowed version of GTMSessionFetcher.

@paulb777
Copy link
Member

Please close, merge, or comment. We plan to close stale PRs on November 28, 2023.

@paulb777 paulb777 closed this Dec 9, 2023
@firebase firebase locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants