Skip to content

Allow multiple DLL hashes #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Allow multiple DLL hashes #1732

wants to merge 2 commits into from

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Allow multiple DLL hashes, in case of supporting multiple versions, debug/release builds, etc.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-labs-jules
Fix: Use sizeof for Analytics DLL hash array
d4a1ab7 
I changed the code in `analytics_desktop.cc` to use
`sizeof(FirebaseAnalytics_WindowsDllHash)` when constructing the
vector for the DLL hash. This replaces the previously hardcoded
size of 32, making the code safer and more maintainable.
@google-labs-jules
Refactor: Adjust log level for hash mismatch in analytics_windows
c6cf8f6 
I changed a LogVerbose call to LogDebug in `VerifyAndLoadAnalyticsLibrary`
within `analytics/src/analytics_windows.cc`.

The log message for a hash size mismatch when iterating through allowed
hashes is now logged at Debug level instead of Verbose.
@jonsimantov jonsimantov changed the title Fix: Use sizeof for Analytics DLL hash array Allow multiple DLL hashes Jun 14, 2025
@jonsimantov jonsimantov marked this pull request as ready for review June 14, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonsimantov