Skip to content

Add Analytics Windows C header and script to generate stubs and function pointers. #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 11, 2025

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jun 11, 2025

Description

Provide details of the change, and generalize the change in the PR title above.

Includes header files for the Analytics Windows SDK, and a script to generate stubs and function pointers to wrap this SDK, so it can be loaded dynamically on Windows. For now this script will be run by hand whenever there is an updated C API.

The windows DLL included contains test stubs, and will only be used for development.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from a-maurice June 11, 2025 19:18
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 11, 2025
@jonsimantov jonsimantov enabled auto-merge (squash) June 11, 2025 21:28
@jonsimantov jonsimantov merged commit e473214 into main Jun 11, 2025
32 of 46 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 11, 2025
Copy link

github-actions bot commented Jun 11, 2025

✅  Integration test succeeded!

Requested by @jonsimantov on commit e473214
Last updated: Wed Jun 11 15:37 PDT 2025
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 11, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants