Skip to content

update end point to developer api #7174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

update end point to developer api #7174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firebase-ai/src/main/kotlin/com/google/firebase/ai/common/APIController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ internal constructor(
}

private fun getBidiEndpoint(location: String): String =
"wss://firebasevertexai.googleapis.com/ws/google.firebase.vertexai.v1beta.LlmBidiService/BidiGenerateContent/locations/$location?key=$key"
"wss://firebasevertexai.googleapis.com//ws/google.firebase.vertexai.v1beta.GenerativeService/BidiGenerateContent?key=$key"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The updated endpoint URL contains a double slash (//) after the hostname. While many clients handle this, it's best practice to correct it to a single slash for clarity and correctness.

Suggested change
"wss://firebasevertexai.googleapis.com//ws/google.firebase.vertexai.v1beta.GenerativeService/BidiGenerateContent?key=$key"
"wss://firebasevertexai.googleapis.com/ws/google.firebase.vertexai.v1beta.GenerativeService/BidiGenerateContent?key=$key"


suspend fun getWebSocketSession(location: String): ClientWebSocketSession =
client.webSocketSession(getBidiEndpoint(location)) { applyCommonHeaders() }
Expand Down