-
Notifications
You must be signed in to change notification settings - Fork 626
feat(appcheck): Implement reCAPTCHA Enterprise App Check provider #7125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e193c14
WIP: feat(appcheck): Implement initial reCAPTCHA Enterprise provider
hiteshmaurya56 5288e7c
WIP: feat(appcheck-recaptcha-enterprise): Add token exchange models a…
hiteshmaurya56 c25340b
WIP: feat(appcheck-network): Extend NetworkClient for reCAPTCHA Enter…
hiteshmaurya56 86c3bbb
WIP: feat(appcheck-network): Extend NetworkClient for reCAPTCHA Enter…
hiteshmaurya56 68ac173
WIP: feat(appcheck-recaptcha-enterprise): Implement RecaptchaEnterpri…
hiteshmaurya56 014dc4a
WIP: chore(appcheck-recaptcha-enterprise): Integrate module into buil…
hiteshmaurya56 2d2b96d
test(appcheck-recaptcha-enterprise): Add unit tests for reCAPTCHA Ent…
hiteshmaurya56 7a99c47
Resolves comments
hiteshmaurya56 c8e295b
Resolves comments
hiteshmaurya56 5f925b4
feat: Add new library versions
hiteshmaurya56 9c34a6e
Resolves build errors
hiteshmaurya56 290a9fb
Fix: Apply Spotless formatting to appcheck-recaptchaenterprise module
hiteshmaurya56 b6dea8d
Fix: Apply Spotless formatting to appcheck-recaptchaenterprise module
hiteshmaurya56 ff30974
Fix: Add api.txt file
hiteshmaurya56 874ef41
Resolves comments
hiteshmaurya56 f30a68e
Resolves comments
hiteshmaurya56 24056ce
Resolves comments
hiteshmaurya56 4027c4d
Resolves comments
hiteshmaurya56 97fc25d
Corrects Formatting
hiteshmaurya56 1f56a6a
Resolves Comments
hiteshmaurya56 8d0f5ee
Removes Map from RecaptchaEnterpriseAppCheckProviderFactory
hiteshmaurya56 beac8e3
Resolves Spotless formatting issue
hiteshmaurya56 b99b2fa
Merge branch 'main' into android-recaptchaenterprise
hiteshmaurya56 4160a2a
Adds existing_api.txt file
hiteshmaurya56 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Signature format: 3.0 | ||
package com.google.firebase.appcheck.recaptchaenterprise { | ||
|
||
public class RecaptchaEnterpriseAppCheckProviderFactory implements com.google.firebase.appcheck.AppCheckProviderFactory { | ||
method public com.google.firebase.appcheck.AppCheckProvider create(com.google.firebase.FirebaseApp); | ||
method public static com.google.firebase.appcheck.recaptchaenterprise.RecaptchaEnterpriseAppCheckProviderFactory getInstance(String); | ||
} | ||
|
||
} | ||
|
10 changes: 10 additions & 0 deletions
10
appcheck/firebase-appcheck-recaptchaenterprise/existing_api.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Signature format: 3.0 | ||
package com.google.firebase.appcheck.recaptchaenterprise { | ||
|
||
public class RecaptchaEnterpriseAppCheckProviderFactory implements com.google.firebase.appcheck.AppCheckProviderFactory { | ||
method public com.google.firebase.appcheck.AppCheckProvider create(com.google.firebase.FirebaseApp); | ||
method public static com.google.firebase.appcheck.recaptchaenterprise.RecaptchaEnterpriseAppCheckProviderFactory getInstance(String); | ||
} | ||
|
||
} | ||
|
68 changes: 68 additions & 0 deletions
68
appcheck/firebase-appcheck-recaptchaenterprise/firebase-appcheck-recaptchaenterprise.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
plugins { | ||
id 'firebase-library' | ||
} | ||
|
||
firebaseLibrary { | ||
libraryGroup = "appcheck" | ||
releaseNotes { | ||
name.set("{{app_check}} Recaptcha Enterprise") | ||
versionName.set("appcheck-recaptchaenterprise") | ||
} | ||
} | ||
|
||
android { | ||
adbOptions { | ||
timeOutInMs 60 * 1000 | ||
} | ||
|
||
namespace "com.google.firebase.appcheck.recaptchaenterprise" | ||
compileSdkVersion project.compileSdkVersion | ||
defaultConfig { | ||
targetSdkVersion project.targetSdkVersion | ||
minSdkVersion project.minSdkVersion | ||
versionName version | ||
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | ||
} | ||
compileOptions { | ||
sourceCompatibility JavaVersion.VERSION_1_8 | ||
targetCompatibility JavaVersion.VERSION_1_8 | ||
} | ||
|
||
testOptions.unitTests.includeAndroidResources = false | ||
} | ||
|
||
dependencies { | ||
implementation(libs.dagger.dagger) | ||
|
||
api project(':appcheck:firebase-appcheck') | ||
api 'com.google.firebase:firebase-common' | ||
api 'com.google.firebase:firebase-components' | ||
api 'com.google.android.recaptcha:recaptcha:18.7.1' | ||
|
||
annotationProcessor(libs.dagger.compiler) | ||
|
||
testImplementation(project(":integ-testing")) { | ||
exclude group: 'com.google.firebase', module: 'firebase-common' | ||
exclude group: 'com.google.firebase', module: 'firebase-components' | ||
} | ||
testImplementation libs.androidx.test.core | ||
testImplementation libs.truth | ||
testImplementation libs.junit | ||
testImplementation libs.mockito.core | ||
testImplementation libs.robolectric | ||
testImplementation libs.org.json | ||
} |
26 changes: 26 additions & 0 deletions
26
appcheck/firebase-appcheck-recaptchaenterprise/src/main/AndroidManifest.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?xml version="1.0" encoding="utf-8"?><!-- Copyright 2025 Google LLC --> | ||
<!-- --> | ||
<!-- Licensed under the Apache License, Version 2.0 (the "License"); --> | ||
<!-- you may not use this file except in compliance with the License. --> | ||
<!-- You may obtain a copy of the License at --> | ||
<!-- --> | ||
<!-- http://www.apache.org/licenses/LICENSE-2.0 --> | ||
<!-- --> | ||
<!-- Unless required by applicable law or agreed to in writing, software --> | ||
<!-- distributed under the License is distributed on an "AS IS" BASIS, --> | ||
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> | ||
<!-- See the License for the specific language governing permissions and --> | ||
<!-- limitations under the License. --> | ||
|
||
<manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
||
<application> | ||
<service | ||
android:name="com.google.firebase.components.ComponentDiscoveryService" | ||
android:exported="false"> | ||
<meta-data | ||
android:name="com.google.firebase.components:com.google.firebase.appcheck.recaptchaenterprise.FirebaseAppCheckRecaptchaEnterpriseRegistrar" | ||
android:value="com.google.firebase.components.ComponentRegistrar" /> | ||
</service> | ||
</application> | ||
</manifest> |
64 changes: 64 additions & 0 deletions
64
...e/firebase/appcheck/recaptchaenterprise/FirebaseAppCheckRecaptchaEnterpriseRegistrar.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.appcheck.recaptchaenterprise; | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import com.google.android.gms.common.annotation.KeepForSdk; | ||
import com.google.firebase.FirebaseApp; | ||
import com.google.firebase.annotations.concurrent.Blocking; | ||
import com.google.firebase.annotations.concurrent.Lightweight; | ||
import com.google.firebase.appcheck.recaptchaenterprise.internal.DaggerProviderComponent; | ||
import com.google.firebase.appcheck.recaptchaenterprise.internal.ProviderMultiResourceComponent; | ||
import com.google.firebase.components.Component; | ||
import com.google.firebase.components.ComponentRegistrar; | ||
import com.google.firebase.components.Dependency; | ||
import com.google.firebase.components.Qualified; | ||
import com.google.firebase.platforminfo.LibraryVersionComponent; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.concurrent.Executor; | ||
|
||
/** | ||
* {@link ComponentRegistrar} for setting up FirebaseAppCheck reCAPTCHA Enterprise's dependency | ||
* injections in Firebase Android Components. | ||
* | ||
* @hide | ||
*/ | ||
@KeepForSdk | ||
public class FirebaseAppCheckRecaptchaEnterpriseRegistrar implements ComponentRegistrar { | ||
private static final String LIBRARY_NAME = "fire-app-check-recaptcha-enterprise"; | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@Override | ||
public List<Component<?>> getComponents() { | ||
Qualified<Executor> liteExecutor = Qualified.qualified(Lightweight.class, Executor.class); | ||
Qualified<Executor> blockingExecutor = Qualified.qualified(Blocking.class, Executor.class); | ||
|
||
return Arrays.asList( | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Component.builder(ProviderMultiResourceComponent.class) | ||
.name(LIBRARY_NAME) | ||
.add(Dependency.required(FirebaseApp.class)) | ||
.add(Dependency.required(liteExecutor)) | ||
.add(Dependency.required(blockingExecutor)) | ||
.factory( | ||
container -> | ||
DaggerProviderComponent.builder() | ||
.setFirebaseApp(container.get(FirebaseApp.class)) | ||
.setLiteExecutor(container.get(liteExecutor)) | ||
.setBlockingExecutor(container.get(blockingExecutor)) | ||
.build() | ||
.getMultiResourceComponent()) | ||
.build(), | ||
LibraryVersionComponent.create(LIBRARY_NAME, BuildConfig.VERSION_NAME)); | ||
} | ||
} |
62 changes: 62 additions & 0 deletions
62
...gle/firebase/appcheck/recaptchaenterprise/RecaptchaEnterpriseAppCheckProviderFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.appcheck.recaptchaenterprise; | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
rlazo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import androidx.annotation.NonNull; | ||
import com.google.firebase.FirebaseApp; | ||
import com.google.firebase.appcheck.AppCheckProvider; | ||
import com.google.firebase.appcheck.AppCheckProviderFactory; | ||
import com.google.firebase.appcheck.FirebaseAppCheck; | ||
import com.google.firebase.appcheck.recaptchaenterprise.internal.ProviderMultiResourceComponent; | ||
import com.google.firebase.appcheck.recaptchaenterprise.internal.RecaptchaEnterpriseAppCheckProvider; | ||
import java.util.Objects; | ||
|
||
/** | ||
* Implementation of an {@link AppCheckProviderFactory} that builds <br> | ||
* {@link RecaptchaEnterpriseAppCheckProvider}s. This is the default implementation. | ||
*/ | ||
public class RecaptchaEnterpriseAppCheckProviderFactory implements AppCheckProviderFactory { | ||
|
||
private final String siteKey; | ||
private volatile RecaptchaEnterpriseAppCheckProvider provider; | ||
|
||
private RecaptchaEnterpriseAppCheckProviderFactory(@NonNull String siteKey) { | ||
this.siteKey = siteKey; | ||
} | ||
|
||
/** Gets an instance of this class for installation into a {@link FirebaseAppCheck} instance. */ | ||
@NonNull | ||
public static RecaptchaEnterpriseAppCheckProviderFactory getInstance(@NonNull String siteKey) { | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Objects.requireNonNull(siteKey, "siteKey cannot be null"); | ||
return new RecaptchaEnterpriseAppCheckProviderFactory(siteKey); | ||
} | ||
|
||
@NonNull | ||
@Override | ||
@SuppressWarnings("FirebaseUseExplicitDependencies") | ||
public AppCheckProvider create(@NonNull FirebaseApp firebaseApp) { | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if (provider == null) { | ||
synchronized (this) { | ||
if (provider == null) { | ||
ProviderMultiResourceComponent component = | ||
firebaseApp.get(ProviderMultiResourceComponent.class); | ||
provider = component.get(siteKey); | ||
provider.initializeRecaptchaClient(); | ||
} | ||
} | ||
} | ||
return provider; | ||
} | ||
} |
44 changes: 44 additions & 0 deletions
44
...rebase/appcheck/recaptchaenterprise/internal/ExchangeRecaptchaEnterpriseTokenRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.appcheck.recaptchaenterprise.internal; | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import androidx.annotation.NonNull; | ||
import androidx.annotation.VisibleForTesting; | ||
import org.json.JSONException; | ||
import org.json.JSONObject; | ||
|
||
/** | ||
* Client-side model of the ExchangeRecaptchaEnterpriseTokenRequest payload from the Firebase App | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* Check Token Exchange API. | ||
*/ | ||
public class ExchangeRecaptchaEnterpriseTokenRequest { | ||
|
||
@VisibleForTesting | ||
static final String RECAPTCHA_ENTERPRISE_TOKEN_KEY = "recaptchaEnterpriseToken"; | ||
|
||
private final String recaptchaEnterpriseToken; | ||
|
||
public ExchangeRecaptchaEnterpriseTokenRequest(@NonNull String recaptchaEnterpriseToken) { | ||
this.recaptchaEnterpriseToken = recaptchaEnterpriseToken; | ||
} | ||
|
||
@NonNull | ||
public String toJsonString() throws JSONException { | ||
JSONObject jsonObject = new JSONObject(); | ||
jsonObject.put(RECAPTCHA_ENTERPRISE_TOKEN_KEY, recaptchaEnterpriseToken); | ||
|
||
return jsonObject.toString(); | ||
} | ||
} |
47 changes: 47 additions & 0 deletions
47
...ain/java/com/google/firebase/appcheck/recaptchaenterprise/internal/ProviderComponent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.appcheck.recaptchaenterprise.internal; | ||
|
||
import com.google.firebase.FirebaseApp; | ||
import com.google.firebase.annotations.concurrent.Blocking; | ||
import com.google.firebase.annotations.concurrent.Lightweight; | ||
import dagger.BindsInstance; | ||
import dagger.Component; | ||
import dagger.Module; | ||
import java.util.concurrent.Executor; | ||
import javax.inject.Singleton; | ||
|
||
@Singleton | ||
@Component(modules = ProviderComponent.MainModule.class) | ||
public interface ProviderComponent { | ||
ProviderMultiResourceComponent getMultiResourceComponent(); | ||
|
||
@Component.Builder | ||
interface Builder { | ||
@BindsInstance | ||
Builder setFirebaseApp(FirebaseApp firebaseApp); | ||
|
||
@BindsInstance | ||
Builder setLiteExecutor(@Lightweight Executor liteExecutor); | ||
|
||
@BindsInstance | ||
Builder setBlockingExecutor(@Blocking Executor blockingExecutor); | ||
|
||
ProviderComponent build(); | ||
} | ||
|
||
@Module | ||
abstract class MainModule {} | ||
} |
57 changes: 57 additions & 0 deletions
57
...google/firebase/appcheck/recaptchaenterprise/internal/ProviderMultiResourceComponent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.appcheck.recaptchaenterprise.internal; | ||
|
||
import androidx.annotation.NonNull; | ||
import dagger.assisted.Assisted; | ||
import dagger.assisted.AssistedFactory; | ||
import java.util.Map; | ||
import java.util.concurrent.ConcurrentHashMap; | ||
import javax.inject.Inject; | ||
import javax.inject.Singleton; | ||
|
||
/** Multi-resource container for RecaptchaEnterpriseAppCheckProvider */ | ||
@Singleton | ||
public final class ProviderMultiResourceComponent { | ||
private final RecaptchaEnterpriseAppCheckProviderFactory providerFactory; | ||
|
||
private final Map<String, RecaptchaEnterpriseAppCheckProvider> instances = | ||
new ConcurrentHashMap<>(); | ||
|
||
@Inject | ||
ProviderMultiResourceComponent(RecaptchaEnterpriseAppCheckProviderFactory providerFactory) { | ||
this.providerFactory = providerFactory; | ||
} | ||
|
||
@NonNull | ||
public RecaptchaEnterpriseAppCheckProvider get(@NonNull String siteKey) { | ||
RecaptchaEnterpriseAppCheckProvider provider = instances.get(siteKey); | ||
hiteshmaurya56 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if (provider == null) { | ||
synchronized (instances) { | ||
provider = instances.get(siteKey); | ||
if (provider == null) { | ||
provider = providerFactory.create(siteKey); | ||
instances.put(siteKey, provider); | ||
} | ||
} | ||
} | ||
return provider; | ||
} | ||
|
||
@AssistedFactory | ||
interface RecaptchaEnterpriseAppCheckProviderFactory { | ||
RecaptchaEnterpriseAppCheckProvider create(@Assisted String siteKey); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.