-
Notifications
You must be signed in to change notification settings - Fork 627
fix(firestore): Further improved performance of UTF-8 string comparison logic #7098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dconeybe
wants to merge
35
commits into
main
Choose a base branch
from
dconeybe/firestore/Utf8StringComparePerformanceFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
5f3ad6f
Utf8Performance{Unit/Integration}Test.kt added
dconeybe 3d231d3
new algorithm skeleton added
dconeybe ab55ee3
add code to fdc demo app so it can be built in release mode
dconeybe 4b45cd2
fix signing for release
dconeybe ba905d4
add Util.java from Firestore
dconeybe cd29244
Utf8PerformanceIntegrationTest.kt added
dconeybe bc51956
MainViewModel.kt: call the performance test
dconeybe 57a0bab
run the test
dconeybe a7a99ef
improve tests
dconeybe 733a1fb
Long -> Duration
dconeybe 28f0766
remove firebase dependencies
dconeybe 8127e5a
enable r8
dconeybe e3f682d
start test button and Trace statements
dconeybe e8b455c
tweaks
dconeybe e0d90ca
Util1.java Util2.java and Util3.java added
dconeybe b92f6ed
fix build
dconeybe 8cc3206
Util4 added, but doesn't support SMP yet.
dconeybe 958954d
Util4: Got SMP done, just need to handle invalid surrogate pairs
dconeybe 28054c0
work
dconeybe c4293a1
Utf8CompareTest.kt added
dconeybe 76365ad
fix test
dconeybe a1625fb
fixes
dconeybe 11308be
Utf8PerformanceIntegrationTest.kt: fix
dconeybe f9f57d0
revert all changes, except Utf8Compare.java
dconeybe 933336b
Util.java: Remove compareUtf8Strings() and switch to the one from Utf…
dconeybe 3612d6b
CHANGELOG.md entry added
dconeybe 29bedd8
Merge branch 'main' into dconeybe/firestore/Utf8StringComparePerforma…
dconeybe 0cf7a45
./gradlew :firebase-firestore:spotlessApply
dconeybe 83ffa93
fix off-by-one error in utf8 logic (thanks copilot!)
dconeybe 5c10ab1
Merge remote-tracking branch 'origin/main' into Utf8StringComparePerf…
dconeybe 02b2f7a
reduce diff from main branch, to make it easier for code review
dconeybe 7d88250
massively simplify the comparison
dconeybe 8e7514b
simplify
dconeybe 429cb1e
Merge branch 'main' into dconeybe/firestore/Utf8StringComparePerforma…
dconeybe 02c2371
reword comment
dconeybe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.