Skip to content

update voice #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025
Merged

update voice #6996

merged 7 commits into from
May 28, 2025

Conversation

VinayGuthal
Copy link
Contributor

@VinayGuthal VinayGuthal commented May 27, 2025

This pr updates the Voice class to take in a string as an attribute instead of just an enum. This is a breaking change since it breaks binary compatibility however I don't think there is any changes that need to be done by the developer

Copy link
Contributor

github-actions bot commented May 27, 2025

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/client/firebase-ai/_toc.yaml	2025-05-28 20:24:27.412098962 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/client/firebase-ai/_toc.yaml	2025-05-28 20:20:44.383024759 +0000
@@ -174,6 +174,8 @@
       path: "/docs/reference/android/com/google/firebase/ai/type/ToolConfig.html"
     - title: "UsageMetadata"
       path: "/docs/reference/android/com/google/firebase/ai/type/UsageMetadata.html"
+    - title: "Voice"
+      path: "/docs/reference/android/com/google/firebase/ai/type/Voice.html"
     - title: "Voices"
       path: "/docs/reference/android/com/google/firebase/ai/type/Voices.html"
 
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ai/type/SpeechConfig.html	2025-05-28 20:24:27.419099019 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ai/type/SpeechConfig.html	2025-05-28 20:20:44.390024801 +0000
@@ -26,7 +26,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voices.html">Voices</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html">Voice</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/ai/type/SpeechConfig.html#voice()">voice</a></code></div>
               <p>The voice to be used for the server's speech response.</p>
@@ -49,7 +49,7 @@
         <tbody class="list">
           <tr>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voices)">SpeechConfig</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voices.html">Voices</a>&nbsp;voice)</code></div>
+              <div><code><a href="/docs/reference/android/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voice)">SpeechConfig</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html">Voice</a>&nbsp;voice)</code></div>
             </td>
           </tr>
         </tbody>
@@ -59,15 +59,15 @@
       <h2>Public fields</h2>
       <div class="api-item"><a name="getVoice()"></a><a name="setVoice()"></a><a name="getVoice--"></a><a name="setVoice--"></a>
         <h3 class="api-name" id="voice()">voice</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voices.html">Voices</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/ai/type/SpeechConfig.html#voice()">voice</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html">Voice</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/ai/type/SpeechConfig.html#voice()">voice</a></pre>
         <p>The voice to be used for the server's speech response.</p>
       </div>
     </div>
     <div class="list">
       <h2>Public constructors</h2>
-      <div class="api-item"><a name="SpeechConfig-com.google.firebase.ai.type.Voices-"></a><a name="speechconfig"></a>
-        <h3 class="api-name" id="SpeechConfig(com.google.firebase.ai.type.Voices)">SpeechConfig</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;<a href="/docs/reference/android/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voices)">SpeechConfig</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voices.html">Voices</a>&nbsp;voice)</pre>
+      <div class="api-item"><a name="SpeechConfig-com.google.firebase.ai.type.Voice-"></a><a name="speechconfig"></a>
+        <h3 class="api-name" id="SpeechConfig(com.google.firebase.ai.type.Voice)">SpeechConfig</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="/docs/reference/android/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voice)">SpeechConfig</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html">Voice</a>&nbsp;voice)</pre>
       </div>
     </div>
   </body>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ai/type/Voice.html	1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ai/type/Voice.html	2025-05-28 20:20:44.395024832 +0000
@@ -0,0 +1,73 @@
+<html devsite="true">
+  <head>
+    <title>Voice</title>
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/android/_reference-head-tags.html" %}
+  </head>
+  <body>
+    <div id="metadata-info-block"></div>
+    <h1>Voice</h1>
+    <p>
+      <pre>@<a href="/docs/reference/android/com/google/firebase/ai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>public final class <a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html">Voice</a></pre>
+    </p>
+    <hr>
+    <p>Various voices supported by the server. The list of all voices can be found <a href="https://cloud.google.com/text-to-speech/docs/chirp3-hd">here</a></p>
+    <h2>Summary</h2>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public fields</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html#voiceName()">voiceName</a></code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public constructors</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html#Voice(kotlin.String)">Voice</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;voiceName)</code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="list">
+      <h2>Public fields</h2>
+      <div class="api-item"><a name="getVoiceName()"></a><a name="setVoiceName()"></a><a name="getVoiceName--"></a><a name="setVoiceName--"></a>
+        <h3 class="api-name" id="voiceName()">voiceName</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html#voiceName()">voiceName</a></pre>
+      </div>
+    </div>
+    <div class="list">
+      <h2>Public constructors</h2>
+      <div class="api-item"><a name="Voice-kotlin.String-"></a><a name="voice"></a>
+        <h3 class="api-name" id="Voice(kotlin.String)">Voice</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html#Voice(kotlin.String)">Voice</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;voiceName)</pre>
+      </div>
+    </div>
+  </body>
+</html>
+
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ai/type/Voices.html	2025-05-28 20:24:27.447099248 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ai/type/Voices.html	2025-05-28 20:20:44.420024984 +0000
@@ -11,6 +11,7 @@
       <pre>@<a href="/docs/reference/android/com/google/firebase/ai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>public final class <a href="/docs/reference/android/com/google/firebase/ai/type/Voices.html">Voices</a></pre>
     </p>
     <hr>
+    <aside class="caution"><strong>This class is deprecated.</strong><br>Please use the Voice class instead.</aside>
     <p>Various voices supported by the server</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ai/type/package-summary.html	2025-05-28 20:24:27.430099109 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ai/type/package-summary.html	2025-05-28 20:20:44.396024838 +0000
@@ -403,9 +403,15 @@
             </td>
           </tr>
           <tr>
+            <td><code><a href="/docs/reference/android/com/google/firebase/ai/type/Voice.html">Voice</a></code></td>
+            <td>
+              <p>Various voices supported by the server.</p>
+            </td>
+          </tr>
+          <tr>
             <td><code><a href="/docs/reference/android/com/google/firebase/ai/type/Voices.html">Voices</a></code></td>
             <td>
-              <p>Various voices supported by the server</p>
+              <p><strong>This class is deprecated.</strong> Please use the Voice class instead.</p>
             </td>
           </tr>
         </tbody>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/client/firebase-ai/_toc.yaml	2025-05-28 20:24:27.485099558 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/client/firebase-ai/_toc.yaml	2025-05-28 20:20:44.439025099 +0000
@@ -162,6 +162,8 @@
       path: "/docs/reference/kotlin/com/google/firebase/ai/type/ToolConfig.html"
     - title: "UsageMetadata"
       path: "/docs/reference/kotlin/com/google/firebase/ai/type/UsageMetadata.html"
+    - title: "Voice"
+      path: "/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html"
     - title: "Voices"
       path: "/docs/reference/kotlin/com/google/firebase/ai/type/Voices.html"
 
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/SpeechConfig.html	2025-05-28 20:24:27.487099575 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/SpeechConfig.html	2025-05-28 20:20:44.441025111 +0000
@@ -27,7 +27,7 @@
         <tbody class="list">
           <tr>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voices)">SpeechConfig</a>(voice:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voices.html">Voices</a>)</code></div>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voice)">SpeechConfig</a>(voice:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html">Voice</a>)</code></div>
             </td>
           </tr>
         </tbody>
@@ -46,7 +46,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voices.html">Voices</a></code></td>
+            <td><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html">Voice</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/SpeechConfig.html#voice()">voice</a></code></div>
               <p>The voice to be used for the server's speech response.</p>
@@ -57,16 +57,16 @@
     </div>
     <div class="list">
       <h2>Public constructors</h2>
-      <div class="api-item"><a name="SpeechConfig-com.google.firebase.ai.type.Voices-"></a><a name="speechconfig"></a>
-        <h3 class="api-name" id="SpeechConfig(com.google.firebase.ai.type.Voices)">SpeechConfig</h3>
-        <pre class="api-signature no-pretty-print"><a href="/docs/reference/kotlin/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voices)">SpeechConfig</a>(voice:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voices.html">Voices</a>)</pre>
+      <div class="api-item"><a name="SpeechConfig-com.google.firebase.ai.type.Voice-"></a><a name="speechconfig"></a>
+        <h3 class="api-name" id="SpeechConfig(com.google.firebase.ai.type.Voice)">SpeechConfig</h3>
+        <pre class="api-signature no-pretty-print"><a href="/docs/reference/kotlin/com/google/firebase/ai/type/SpeechConfig.html#SpeechConfig(com.google.firebase.ai.type.Voice)">SpeechConfig</a>(voice:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html">Voice</a>)</pre>
       </div>
     </div>
     <div class="list">
       <h2>Public properties</h2>
       <div class="api-item"><a name="getVoice()"></a><a name="setVoice()"></a><a name="getVoice--"></a><a name="setVoice--"></a>
         <h3 class="api-name" id="voice()">voice</h3>
-        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/SpeechConfig.html#voice()">voice</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voices.html">Voices</a></pre>
+        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/SpeechConfig.html#voice()">voice</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html">Voice</a></pre>
         <p>The voice to be used for the server's speech response.</p>
       </div>
     </div>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/Voice.html	1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/Voice.html	2025-05-28 20:20:44.449025160 +0000
@@ -0,0 +1,73 @@
+<html devsite="true">
+  <head>
+    <title>Voice</title>
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/kotlin/_reference-head-tags.html" %}
+  </head>
+  <body>
+    <div id="metadata-info-block"></div>
+    <h1>Voice</h1>
+    <p>
+      <pre>@<a href="/docs/reference/kotlin/com/google/firebase/ai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>class <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html">Voice</a></pre>
+    </p>
+    <hr>
+    <p>Various voices supported by the server. The list of all voices can be found <a href="https://cloud.google.com/text-to-speech/docs/chirp3-hd">here</a></p>
+    <h2>Summary</h2>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public constructors</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html#Voice(kotlin.String)">Voice</a>(voiceName:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public properties</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html#voiceName()">voiceName</a></code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="list">
+      <h2>Public constructors</h2>
+      <div class="api-item"><a name="Voice-kotlin.String-"></a><a name="voice"></a>
+        <h3 class="api-name" id="Voice(kotlin.String)">Voice</h3>
+        <pre class="api-signature no-pretty-print"><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html#Voice(kotlin.String)">Voice</a>(voiceName:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</pre>
+      </div>
+    </div>
+    <div class="list">
+      <h2>Public properties</h2>
+      <div class="api-item"><a name="getVoiceName()"></a><a name="setVoiceName()"></a><a name="getVoiceName--"></a><a name="setVoiceName--"></a>
+        <h3 class="api-name" id="voiceName()">voiceName</h3>
+        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html#voiceName()">voiceName</a>:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a></pre>
+      </div>
+    </div>
+  </body>
+</html>
+
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/Voices.html	2025-05-28 20:24:27.527099901 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/Voices.html	2025-05-28 20:20:44.465025257 +0000
@@ -11,6 +11,7 @@
       <pre>@<a href="/docs/reference/kotlin/com/google/firebase/ai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>class <a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voices.html">Voices</a></pre>
     </p>
     <hr>
+    <aside class="caution"><strong>This class is deprecated.</strong><br>Please use the Voice class instead.</aside>
     <p>Various voices supported by the server</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/package-summary.html	2025-05-28 20:24:27.501099689 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/ai/type/package-summary.html	2025-05-28 20:20:44.450025166 +0000
@@ -368,9 +368,15 @@
             </td>
           </tr>
           <tr>
+            <td><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voice.html">Voice</a></code></td>
+            <td>
+              <p>Various voices supported by the server.</p>
+            </td>
+          </tr>
+          <tr>
             <td><code><a href="/docs/reference/kotlin/com/google/firebase/ai/type/Voices.html">Voices</a></code></td>
             <td>
-              <p>Various voices supported by the server</p>
+              <p><strong>This class is deprecated.</strong> Please use the Voice class instead.</p>
             </td>
           </tr>
         </tbody>

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 27, 2025

Copy link
Contributor

github-actions bot commented May 27, 2025

Test Results

 24 files   -  40   24 suites   - 40   34s ⏱️ - 5m 29s
102 tests  - 385  102 ✅  - 385  0 💤 ±0  0 ❌ ±0 
204 runs   - 776  204 ✅  - 776  0 💤 ±0  0 ❌ ±0 

Results for commit 7c66918. ± Comparison against base commit 366095f.

This pull request removes 487 and adds 102 tests. Note that renamed tests count towards both.
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ image rejected
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ prompt blocked for safety
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ short reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ stopped for recitation
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ citation returns correctly
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ invalid api key
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ response blocked for safety
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-ai:
error: Added constructor com.google.firebase.ai.type.Voices(String) [AddedMethod]
error: Removed method com.google.firebase.ai.type.Voices.getOrdinal() [RemovedMethod]
error: Added method com.google.firebase.ai.type.Voices.getVoiceName() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-ai:
error: Added constructor com.google.firebase.ai.type.Voices(String) [AddedMethod]
error: Removed method com.google.firebase.ai.type.Voices.getOrdinal() [RemovedMethod]
error: Added method com.google.firebase.ai.type.Voices.getVoiceName() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 27, 2025

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (366095f)Merge (19e7dbd)Diff
    aar819 kB825 kB+5.85 kB (+0.7%)
    apk (aggressive)1.55 MB1.55 MB+2.08 kB (+0.1%)
    apk (release)9.52 MB9.52 MB+2.92 kB (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ia223JQMNg.html

@VinayGuthal VinayGuthal requested a review from rlazo May 28, 2025 19:00
@VinayGuthal VinayGuthal requested a review from rlazo May 28, 2025 20:07
@VinayGuthal VinayGuthal enabled auto-merge (squash) May 28, 2025 20:08
@VinayGuthal VinayGuthal merged commit af24598 into main May 28, 2025
30 of 32 checks passed
@VinayGuthal VinayGuthal deleted the update_bidi branch May 28, 2025 20:44
emilypgoogle pushed a commit that referenced this pull request May 28, 2025
This pr updates the Voice class to take in a string as an attribute
instead of just an enum. This is a breaking change since it breaks
binary compatibility however I don't think there is any changes that
need to be done by the developer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants