Skip to content

Verify smoke tests #6994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Verify smoke tests #6994

wants to merge 1 commit into from

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented May 27, 2025

No description provided.

Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

Test Results

 57 files   -   7   57 suites   - 7   1m 16s ⏱️ - 1m 5s
970 tests +651  961 ✅ +643  0 💤  - 1  9 ❌ +9 
978 runs  +336  969 ✅ +329  0 💤  - 2  9 ❌ +9 

For more details on these failures, see this check.

Results for commit da3cc07. ± Comparison against base commit ec4b353.

This pull request removes 319 and adds 970 tests. Note that renamed tests count towards both.
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addClickListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDismissListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDisplayErrorListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addImpressionListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveAllListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_clearsInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_disablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionEnabling_enablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ clearDisplayListener_removesListener
…
com.google.firebase.perf.FirebasePerfRegistrarTest ‑ testGetComponents
com.google.firebase.perf.FirebasePerformanceTest ‑ firebasePerformanceInitialization_providesRcProvider_remoteConfigManagerIsSet
com.google.firebase.perf.FirebasePerformanceTest ‑ initFirebasePerformance_injectsMetadataIntoConfigResolver
com.google.firebase.perf.FirebasePerformanceTest ‑ initializeFirebasePerformance_emptyMetadataAndCache_metadataAndContextInjected
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsManifestTrue
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsManifestFalse
com.google.firebase.perf.FirebasePerformanceTest ‑ testAddingMoreThanMaxLocalAttributes
com.google.firebase.perf.FirebasePerformanceTest ‑ testBothManifestsAgree
…

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-perf

    TypeBase (ec4b353)Merge (9890901)Diff
    aar316 kB316 kB+84 B (+0.0%)
    apk (aggressive)1.63 MB1.63 MB+88 B (+0.0%)
    apk (release)10.1 MB10.1 MB+36 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SjBGs2D46L.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-perf

    DeviceStatisticsDistributions
    oriole-32
    Percentileec4b3539890901DiffSignificant (?)
    p10266 ±18 μs260 ±22 μs-5.68 μs (-2.1%)NO
    p25276 ±15 μs271 ±22 μs-5.57 μs (-2.0%)NO
    p50292 ±13 μs287 ±20 μs-4.96 μs (-1.7%)NO
    p75323 ±13 μs321 ±21 μs-1.87 μs (-0.6%)NO
    p90365 ±22 μs394 ±40 μs+28.4 μs (+7.8%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    9890901
    • 2025-05-27_15:37:32.148876_Khuh
    • 2025-05-27_15:37:32.148910_cEwU
    • 2025-05-27_15:37:32.148917_YlTT
    • 2025-05-27_15:37:32.148970_KKRJ
    • 2025-05-27_15:37:32.148980_XsHz
    • 2025-05-27_15:37:32.148987_VCDt
    • 2025-05-27_15:37:32.148994_OfOv
    • 2025-05-27_15:37:32.149001_AwBQ
    • 2025-05-27_15:37:32.149008_Qmsr
    • 2025-05-27_15:37:32.149015_tvrZ
    redfin-30
    Percentileec4b3539890901DiffSignificant (?)
    p10723 ±64 μs750 ±49 μs+27.3 μs (+3.8%)NO
    p25769 ±56 μs787 ±48 μs+18.4 μs (+2.4%)NO
    p50836 ±50 μs856 ±56 μs+19.6 μs (+2.3%)NO
    p75917 ±59 μs962 ±72 μs+45.4 μs (+5.0%)NO
    p901.01 ±0.09 ms1.06 ±0.07 ms+53.0 μs (+5.2%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    9890901
    • 2025-05-27_15:37:32.148876_Khuh
    • 2025-05-27_15:37:32.148910_cEwU
    • 2025-05-27_15:37:32.148917_YlTT
    • 2025-05-27_15:37:32.148970_KKRJ
    • 2025-05-27_15:37:32.148980_XsHz
    • 2025-05-27_15:37:32.148987_VCDt
    • 2025-05-27_15:37:32.148994_OfOv
    • 2025-05-27_15:37:32.149001_AwBQ
    • 2025-05-27_15:37:32.149008_Qmsr
    • 2025-05-27_15:37:32.149015_tvrZ
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentileec4b3539890901DiffSignificant (?)
    p102.35 ±1 ms2.30 ±0.7 ms-51.4 μs (-2.2%)NO
    p252.55 ±1 ms2.48 ±0.7 ms-63.0 μs (-2.5%)NO
    p502.94 ±1 ms2.86 ±0.7 ms-84.6 μs (-2.9%)NO
    p753.59 ±1 ms3.48 ±0.7 ms-111 μs (-3.1%)NO
    p904.41 ±1 ms4.27 ±0.9 ms-139 μs (-3.2%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    9890901
    • 2025-05-27_15:37:32.148876_Khuh
    • 2025-05-27_15:37:32.148910_cEwU
    • 2025-05-27_15:37:32.148917_YlTT
    • 2025-05-27_15:37:32.148970_KKRJ
    • 2025-05-27_15:37:32.148980_XsHz
    • 2025-05-27_15:37:32.148987_VCDt
    • 2025-05-27_15:37:32.148994_OfOv
    • 2025-05-27_15:37:32.149001_AwBQ
    • 2025-05-27_15:37:32.149008_Qmsr
    • 2025-05-27_15:37:32.149015_tvrZ
    redfin-30
    Percentileec4b3539890901DiffSignificant (?)
    p104.30 ±0.9 ms4.63 ±1 ms+332 μs (+7.7%)NO
    p254.68 ±1 ms5.07 ±1 ms+390 μs (+8.3%)NO
    p505.24 ±1 ms5.83 ±2 ms+589 μs (+11.2%)NO
    p755.98 ±2 ms7.11 ±3 ms+1.13 ms (+18.9%)NO
    p906.85 ±2 ms8.63 ±5 ms+1.78 ms (+26.0%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    9890901
    • 2025-05-27_15:37:32.148876_Khuh
    • 2025-05-27_15:37:32.148910_cEwU
    • 2025-05-27_15:37:32.148917_YlTT
    • 2025-05-27_15:37:32.148970_KKRJ
    • 2025-05-27_15:37:32.148980_XsHz
    • 2025-05-27_15:37:32.148987_VCDt
    • 2025-05-27_15:37:32.148994_OfOv
    • 2025-05-27_15:37:32.149001_AwBQ
    • 2025-05-27_15:37:32.149008_Qmsr
    • 2025-05-27_15:37:32.149015_tvrZ
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileec4b3539890901DiffSignificant (?)
    p10199 ±5 ms201 ±6 ms+1.38 ms (+0.7%)NO
    p25204 ±5 ms206 ±6 ms+2.01 ms (+1.0%)NO
    p50212 ±5 ms215 ±6 ms+3.42 ms (+1.6%)NO
    p75219 ±5 ms224 ±6 ms+5.14 ms (+2.4%)NO
    p90225 ±6 ms234 ±7 ms+9.18 ms (+4.1%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    9890901
    • 2025-05-27_15:37:32.148876_Khuh
    • 2025-05-27_15:37:32.148910_cEwU
    • 2025-05-27_15:37:32.148917_YlTT
    • 2025-05-27_15:37:32.148970_KKRJ
    • 2025-05-27_15:37:32.148980_XsHz
    • 2025-05-27_15:37:32.148987_VCDt
    • 2025-05-27_15:37:32.148994_OfOv
    • 2025-05-27_15:37:32.149001_AwBQ
    • 2025-05-27_15:37:32.149008_Qmsr
    • 2025-05-27_15:37:32.149015_tvrZ
    redfin-30
    Percentileec4b3539890901DiffSignificant (?)
    p10225 ±5 ms247 ±3 ms+21.6 ms (+9.6%)MAYBE
    p25232 ±5 ms254 ±4 ms+22.3 ms (+9.6%)MAYBE
    p50239 ±4 ms261 ±4 ms+22.6 ms (+9.5%)YES
    p75247 ±5 ms271 ±5 ms+23.6 ms (+9.6%)MAYBE
    p90257 ±6 ms284 ±10 ms+27.3 ms (+10.6%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    9890901
    • 2025-05-27_15:37:32.148876_Khuh
    • 2025-05-27_15:37:32.148910_cEwU
    • 2025-05-27_15:37:32.148917_YlTT
    • 2025-05-27_15:37:32.148970_KKRJ
    • 2025-05-27_15:37:32.148980_XsHz
    • 2025-05-27_15:37:32.148987_VCDt
    • 2025-05-27_15:37:32.148994_OfOv
    • 2025-05-27_15:37:32.149001_AwBQ
    • 2025-05-27_15:37:32.149008_Qmsr
    • 2025-05-27_15:37:32.149015_tvrZ

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Wv6XhvXNgu/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants