Skip to content

[Ai] Update test response check to verify firebase-ai #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

[Ai] Update test response check to verify firebase-ai #6926

merged 3 commits into from
May 6, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 1, 2025

Instead of verifying vertexAI, we should do the verification on firebase-ai only.

@rlazo
[Ai] Update test response check to verify firebase-ai
fb493bf 
Instead of verifying vertexAI, we should do the verification on
firebase-ai only.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested review from daymxn and emilypgoogle May 1, 2025 22:05
@rlazo rlazo enabled auto-merge (squash) May 1, 2025 22:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2025 •
edited
Loading

Test Results

 1 094 files  + 1 072   1 094 suites  +1 072   36m 16s ⏱️ + 35m 42s
 5 974 tests + 5 874   5 951 ✅ + 5 851  22 💤 +22  1 ❌ +1 
12 659 runs  +12 459  12 614 ✅ +12 414  44 💤 +44  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 43d2858. ± Comparison against base commit bbe3de1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 1, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (bbe3de1) and merge commit (ed13b6e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YkLWWOtjQS.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 1, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-storage

    Overall coverage changed from 83.96% (bbe3de1) to 84.33% (ed13b6e) by +0.37%.

    FilenameBase (bbe3de1)Merge (ed13b6e)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.52%83.17%+1.65%

  • firebase-firestore

    FilenameBase (bbe3de1)Merge (ed13b6e)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6lBil2sxyD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 1, 2025 •
edited
Loading

Startup Time Report 1

The report is too large (122,582 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gyYxYLcwZQ/index.html

@rlazo
Copy link
Collaborator Author

rlazo commented May 5, 2025

friendly ping

@rlazo rlazo merged commit 525f293 into main May 6, 2025
423 of 427 checks passed
@rlazo rlazo deleted the rl.vertex.check.update branch May 6, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daymxn daymxn daymxn approved these changes

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @daymxn