Rebase main #6709
Merged
Rebase main #6709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [b/384956859](https://b.corp.google.com/issues/384956859), This migrates all of our root build files to `kts`. It also refactors our usages to be more inline with modern gradle practices. Furthermore, this PR also fixes the following: - [b/384956861](https://b.corp.google.com/issues/384956861) -> Provide fallback for build script names
Per [b/384990125](https://b.corp.google.com/issues/384990125), This migrates all of our `buildSrc` logic into a composite plugin called `plugins`. This PR makes no attempt to organize the code; that is out-of-scope for the PR. This PR also fixes various references to `buildSrc` (including markdown links), to avoid any breakage.
Adjusted Functions docs as well as vestigial visibility issues.
…amp to explicitly document using the `@get` and/or `@set` use-site targets on Kotlin properties (#6612)
feat(rc): Add support to set custom signals for Remote Config Custom targeting
We have been using the spotless plugin for a while already.
Per [b/391351857](https://b.corp.google.com/issues/391351857), This refactors the `VendorPlugin` and `VendorTask` to be more compliant with the gradle cache and configuration avoidance. It also adds proper task logging and documentation to both the task and the plugin. This PR also fixes the following: - [b/391352175](https://b.corp.google.com/issues/391352175) -> Rename plugin Util files to Extensions
The SDK was released as GA last year.
Replace the changed tag with deprecated for the last FDL release
Per [b/392134866](https://b.corp.google.com/issues/392134866), This implements a centralized interface for communicating with GMaven called `GMavenService`. This service implements the gradle build-service interface to provide proper parallel access, and keeps local `ConcurrentHashMap` instances to cache responses. Cached responses are on a _per-build_ basis, to avoid improper caching of dynamic data. That is, given any build- **all** tasks that utilize `GMavenService` will share the responses from GMaven; even within a parallel environment. But if the tasks are considered out-of-date and are ran again, then new requests will be made to the GMaven backend. Tests and documentation are provided for everything added as well. Note that while this PR _implements_ `GMavenService`- it does _not_ refactor the existing `GMavenHelper` and `RepositoryClient` usages to use it. That will occur in subsequent PRs, as to avoid polluting this PR. Furthermore, while there are no tests for `PomElement` directly- in a future PR that includes tests for bom generation, `PomElement` will be tested as a by-product. This PR also fixes the following: - [b/392135224](https://b.corp.google.com/issues/392135224) -> Implement centralized pom datamodel
Empty text parts go from a nuance when processed, to an exception when send to the backend. To prevent this issue, we are dropping them when parsing the response from the server.
We've updated from version 3.* to 5.*. Test were added were necessary to match the coverage in the iOS repo. A few changes (v5.1 and v5.2) don't have tests covering the new files yet
There are some considerations to how this should be finalized. Current implementation details that I've decided on which we can change: * Based on the example doc, all classes `Foo` have been renamed `InternalFoo` * All internal serialization classes, where relevant, are moved to inner classes of their API counterparts * All classes only used as child fields for serialization classes have been moved to inner classes of those classes * All `toPublic` and `toInternal` methods on API and serialization classes have been moved inside of those classes and `conversions.kt` has been mostly emptied. * A few serialization classes do not have API equivalents and are left in a `Types.kt` file Possible changes: * Change all `InternalFoo` classes to have the same name, referenced as `Foo.Internal` rather than `Foo.InternalFoo`. This will probably make the codebase feel cleaner, but I'll wait for opinions on it * Move serialization only classes out of the internal serialization classes, either to inner classes of the API classes or top level classes themselves. * For classes that have serializers, rename serializers from `InternalFooSerializer` to `Serializer` for example `Foo.InternalFoo.Serializer` or `Foo.Internal.Serializer` instead of `Foo.InternalFoo.InternalFooSerializer` or `Foo.Internal.InternalFooSerializer`
Adds the changelog entry for #6652
Per [b/393388687](https://b.corp.google.com/issues/393388687), This updates the `core-ktx` version to be `1.12.0` instead of `1.9.0`. This version was accidentally downgraded in #6584.
Auto-generated PR for cleaning up release m158 NO_RELEASE_CHANGE --------- Co-authored-by: daymxn <daymxn@users.noreply.github.com> Co-authored-by: Daymon <daymxn@google.com>
The old version was failing to succeed, this version was tested and works --------- Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
This updates the changelog entries that had their contents changed in the m150 CL. NO_RELEASE_CHANGE
This includes adding vertex ai api.txt which we were lacking until now
Per [b/394616465](https://b.corp.google.com/issues/394616465), This refactors our bom generation and all of the bom related tasks to solve the following issues: 1. Testability. 2. Gradle cache and config avoidance compliance. 3. Generation of bom, bom release notes, and tutorial bundle in isolation of each other. 4. Documentation. 5. Usage of classes that were only used for bom generation (of which, suitable replacements were used elsewhere in our plugin logic). Effectively, this PR splits bom generation into 3 tasks: `GenerateBomTask`, `GenerateBomReleaseNotesTask`, and `GenerateTutorialBundleTask`. These 3 tasks get ran together during the release, but them being separated now makes it easier to not only run them in isolation of each other- but test them in isolation. As such, this PR also includes tests for all of the bom related tasks, and documentation for everything. These tasks also take advantage of the new `GMavenService`- to support proper parallel execution and caching. And finally, the configuration of these tasks has been moved to the use-site instead of the declaration site, to more cleanly match other tasks and the configuration style that the Gradle team pushes. This PR also fixes the following: - [b/394614707](https://b.corp.google.com/issues/394614707) -> Move tutorial bundle generation to its own task - [b/394614708](https://b.corp.google.com/issues/394614708) -> Move bom release note generation to its own task - [b/394614709](https://b.corp.google.com/issues/394614709) -> Create a new task for bom generation - [b/394615027](https://b.corp.google.com/issues/394615027) -> Add tests for bom related tasks
Per [b/394908865](https://b.corp.google.com/issues/394908865), This fixes an issue where `ModuleVersion.bump()` was not properly resetting the smaller version types. Additionally, this fixes some other minor issues with bom generation. Namely, this PR also fixes: - [b/394908773](https://b.corp.google.com/issues/394908773) -> Fix bom release note ordering - [b/394909103](https://b.corp.google.com/issues/394909103) -> Separate published bom artifacts
Auto-generated PR for cleaning up release m159 NO_RELEASE_CHANGE --------- Co-authored-by: daymxn <daymxn@users.noreply.github.com> Co-authored-by: Daymon <daymxn@google.com>
… 1.7.6 and 1.7.7 (#6684)
Token measurement is broken down by modaliy, with separate counters for image, audio, etc. Tests are in version 6.*, so this change also includes bumping update_responses.sh
Co-authored-by: David Motsonashvili <davidmotson@google.com> Co-authored-by: Rodrigo Lazo <rlazo@users.noreply.github.com>
Fix deprecated message in KeyValueBuilder to render properly
Changelog entry should be picked up for the next release
If missing, they'll default to empty.
The current refdocs are somewhat confusing and may lead to assume that the conversion happens server-side, when it's actually client side.
Added support for querying imagen models to generate images both in gcs and inline. Documentation incoming in a separate PR for readability --------- Co-authored-by: David Motsonashvili <davidmotson@google.com> Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com> Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Scorecard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.