Drop empty text parts when parsing the model's response #6652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty text parts go from a nuance when processed, to an exception when send to the backend. To prevent this issue, we are dropping them when parsing the response from the server.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (b17d041) and merge commit (8109f08).Test Logs |
Test Results 20 files - 1 014 20 suites - 1 014 12s ⏱️ - 34m 16s Results for commit 36385d2. ± Comparison against base commit b17d041. This pull request removes 5775 tests. |
Size Report 1Affected Products
Test Logs |
davidmotson
approved these changes
Jan 28, 2025
Merged
daymxn
added a commit
that referenced
this pull request
Jan 29, 2025
Adds the changelog entry for #6652
daymxn
added a commit
that referenced
this pull request
Jan 30, 2025
Adds the changelog entry for #6652
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty text parts go from a nuance when processed, to an exception when send to the backend. To prevent this issue, we are dropping them when parsing the response from the server.