Ensure that on-demand fatal events are never processed on the main thread #6113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-crashlytics### {{crashlytics}} version 19.0.4 {: #crashlytics_v19-0-4}
* {{feature}} Added the `isCrashlyticsCollectionEnabled` API to check if Crashlytics collection is enabled.
([Github #5919](//github.com/firebase/firebase-android-sdk/issues/5919))
* {{fixed}} Ensure that on-demand fatal events are never processed on the main thread.
#### {{crashlytics}} Kotlin extensions version 19.0.4 {: #crashlytics-ktx_v19-0-4}
The Kotlin extensions library transitively includes the updated
`firebase-crashlytics` library. The Kotlin extensions library has no additional
updates. |
Coverage Report 1Affected Products
Test Logs |
Unit Test Results 8 files - 42 8 suites - 42 24s ⏱️ -59s Results for commit deee48a. ± Comparison against base commit d583311. This pull request removes 76 and adds 22 tests. Note that renamed tests count towards both. |
Size Report 1Affected Products
Test Logs |
themiswang
approved these changes
Jul 18, 2024
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that on-demand fatal events are never processed on the main thread.
Also decreased the timeout on main to under 3 seconds, to give more time to other uncaught exception handlers in the chain.
Also fixed some formatting.
Tested cases:
Uncaught exception thrown from the main thread
Uncaught exception thrown from a background thread
ODF triggered on the main thread
ODF triggered on a background thread