Skip to content

Add semver test for PRs targeting master #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/semver-check-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Release Semver Check

on:
workflow_dispatch:
pull_request:
branches:
- 'releases/**'

jobs:
semver-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3.5.3

- name: Perform gradle build
run: |
./gradlew semverCheckForRelease
61 changes: 56 additions & 5 deletions .github/workflows/semver-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,65 @@ on:
workflow_dispatch:
pull_request:
branches:
- 'releases/**'
- 'master'

jobs:
semver-check:
runs-on: ubuntu-latest
determine_changed:
name: "Determine changed modules"
runs-on: ubuntu-22.04
if: (github.repository == 'Firebase/firebase-android-sdk' && github.event_name == 'push') || github.event_name == 'pull_request'
outputs:
modules: ${{ steps.changed-modules.outputs.modules }}
steps:
- uses: actions/checkout@v3.5.3
with:
fetch-depth: 2
submodules: true

- name: Perform gradle build
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
java-version: 11
distribution: temurin
cache: gradle

- id: changed-modules
run: |
git diff --name-only HEAD~1 | xargs printf -- '--changed-git-paths %s\n' | xargs ./gradlew writeChangedProjects --only-firebase-sdks --output-file-path=modules.json
echo modules=$(cat modules.json) >> $GITHUB_OUTPUT

semver_checks:
name: "Semver Checks"
runs-on: ubuntu-22.04
needs:
- determine_changed
strategy:
fail-fast: false
matrix:
module: ${{ fromJSON(needs.determine_changed.outputs.modules) }}

steps:
- uses: actions/checkout@v3.5.3

- name: Set up JDK 11
uses: actions/setup-java@v3
with:
java-version: 11
distribution: temurin
cache: gradle

- name: ${{ matrix.module }} Semver Check
run: |
./gradlew semverCheckForRelease
./gradlew ${{matrix.module}}:semverCheck

# A job that fails if any job in the semver_checks matrix fails,
# to be used as a required check for merging.
check_all:
runs-on: ubuntu-22.04
if: always()
name: Semver Check (matrix)
needs: semver_checks
steps:
- name: Check test matrix
if: needs.semver_checks.result != 'success'
run: exit 1
2 changes: 1 addition & 1 deletion firebase-common/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
version=20.4.3
version=20.5.0
latestReleasedVersion=20.4.2
android.enableUnitTestBinaryResources=true
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.

version=16.0.1
version=17.0.0
latestReleasedVersion=16.0.0-beta03
2 changes: 1 addition & 1 deletion firebase-config/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.
#

version=21.6.2
version=22.0.0
latestReleasedVersion=21.6.1
android.enableUnitTestBinaryResources=true

2 changes: 1 addition & 1 deletion firebase-database-collection/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version=18.0.2
version=19.0.0
latestReleasedVersion=18.0.1
2 changes: 1 addition & 1 deletion firebase-inappmessaging-display/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version=20.4.1
version=20.5.0
latestReleasedVersion=20.4.0
2 changes: 1 addition & 1 deletion firebase-inappmessaging/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version=20.4.1
version=20.5.0
latestReleasedVersion=20.4.0
2 changes: 1 addition & 1 deletion protolite-well-known-types/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# IMPORTANT (b/285892320) Keep version and latestReleasedVersion in sync
# unless you are releasing a new version of the library to prevent issues
# with transitive dependencies.
version=18.0.0
version=19.0.0
latestReleasedVersion=18.0.0