Skip to content

Allow setting impression/dismiss thresholds in FirebaseInAppMessagingDisplay #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow setting impression/dismiss thresholds in FirebaseInAppMessagingDisplay #4732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions ...c/main/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,8 @@
*/
@FirebaseAppScope
public class FirebaseInAppMessagingDisplay extends FirebaseInAppMessagingDisplayImpl {
static final long IMPRESSION_THRESHOLD_MILLIS = 5 * 1000; // 5 seconds is a valid impression
static final long DISMISS_THRESHOLD_MILLIS =
20 * 1000; // auto dismiss after 20 seconds for banner
static long impressionThresholdMillis = 5 * 1000; // 5 seconds is a valid impression
static long dismissThresholdMillis = 20 * 1000; // auto dismiss after 20 seconds for banner
static final long INTERVAL_MILLIS = 1000;

private final FirebaseInAppMessaging headlessInAppMessaging;
Expand Down Expand Up @@ -131,6 +130,22 @@ public static FirebaseInAppMessagingDisplay getInstance() {
return FirebaseApp.getInstance().get(FirebaseInAppMessagingDisplay.class);
}

public static long getImpressionThresholdMillis() {
return impressionThresholdMillis;
}

public static void setImpressionThresholdMillis(long impressionThresholdMillis) {
FirebaseInAppMessagingDisplay.impressionThresholdMillis = impressionThresholdMillis;
}

public static long getDismissThresholdMillis() {
return dismissThresholdMillis;
}

public static void setDismissThresholdMillis(long dismissThresholdMillis) {
FirebaseInAppMessagingDisplay.dismissThresholdMillis = dismissThresholdMillis;
}

private static int getScreenOrientation(Application app) {
return app.getResources().getConfiguration().orientation;
}
Expand Down Expand Up @@ -389,7 +404,7 @@ public void onFinish() {
}
}
},
IMPRESSION_THRESHOLD_MILLIS,
impressionThresholdMillis,
INTERVAL_MILLIS);

// Setup auto dismiss timer
Expand All @@ -405,7 +420,7 @@ public void onFinish() {
dismissFiam(activity);
}
},
DISMISS_THRESHOLD_MILLIS,
dismissThresholdMillis,
INTERVAL_MILLIS);
}

Expand Down
4 changes: 2 additions & 2 deletions ...st/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ public void streamListener_whenImageLoadSucceeds_startsImpressionTimer() {
any(RenewableTimer.Callback.class),
ArgumentMatchers.eq(
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplay
.IMPRESSION_THRESHOLD_MILLIS),
.impressionThresholdMillis),
ArgumentMatchers.eq(
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplay
.INTERVAL_MILLIS));
Expand All @@ -473,7 +473,7 @@ public void streamListener_whenImageLoadSucceedsForAutoDismissFiam_startsDismiss
any(RenewableTimer.Callback.class),
ArgumentMatchers.eq(
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplay
.DISMISS_THRESHOLD_MILLIS),
.dismissThresholdMillis),
ArgumentMatchers.eq(
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplay
.INTERVAL_MILLIS));
Expand Down