refactor: improve partitioning code #2447
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
force-pushed
the
@invertase/fix-partitioning-2
branch
from
b2060ac to
c2e01b4
Compare
cabljac
commented
Jun 12, 2025
| } | ||
| import type { Config } from "./types"; | ||
| import { PartitioningConfig } from "./partitioning/config"; | ||
| export type { Config } from "./types"; |
There was a problem hiding this comment.
We will have to decide what to name this type we're exporting
There was a problem hiding this comment.
@CorieW suggestions here?
There was a problem hiding this comment.
maybe we just keep it the same
cabljac
commented
Jun 12, 2025
| @@ -5,7 +5,7 @@ | |||
| "url": "github.com/firebase/extensions.git", | |||
| "directory": "firestore-bigquery-export/firestore-bigquery-change-tracker" | |||
| }, | |||
| "version": "1.1.38", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
made it a breaking change as API for package changes
CorieW
approved these changes
Jul 3, 2025
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a fresh attempt at refactoring partitioning so it is easier to reason about.