-
Notifications
You must be signed in to change notification settings - Fork 130
fix: 946 associate commits by email #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: 946 associate commits by email #973
Conversation
Git user.name may not be set to the GitHub username. GitHub uses the email address for lookup
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Looks like I didn't check the CLI test cases and need to sort something out there |
Fixed the failing tests but am waiting on a review (in git proxy), will update monday |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
+ Coverage 49.82% 56.26% +6.43%
==========================================
Files 48 48
Lines 1724 1733 +9
Branches 176 178 +2
==========================================
+ Hits 859 975 +116
+ Misses 841 727 -114
- Partials 24 31 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code coverage is as good as I can get it, will pick up a little more when #979 is merged |
@JamieSlome @coopernetes @grovesy this is ready for a review. I think this will be important to supporting anything other than GitHub (alongside a fix for #950). |
resolves #946
Updates push parsing to extract commiter emails and to associate commits with users via email, rather than the git user.name config.
Note that:
https://docs.github.com/en/get-started/git-basics/setting-your-username-in-git
and
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address