-
Notifications
You must be signed in to change notification settings - Fork 138
refactor: Refactor service
module to TS + ESM
#1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
+ Coverage 76.78% 77.27% +0.49%
==========================================
Files 55 54 -1
Lines 2261 2187 -74
Branches 251 342 +91
==========================================
- Hits 1736 1690 -46
+ Misses 495 445 -50
- Partials 30 52 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
By the way, @06kellyjac, the OIDC is still working correctly after your passport changes 👍🏼 I tried merging in your ActiveDirectory additions and refactoring them into TS, but I'm not sure if they work 100% as intended. Would appreciate a quick look at this to make sure! |
Fixes #1062.
This PR is built on top of #977 which should merged first (and is ready to merge!).Note that some
.post
requests useres: any
instead ofres: Response
. For some reason, when usingres: Response
, I was getting this (unhelpful) error:I have no idea why it seems to require the type
Application
(from the Express library), but when setting it to typeany
the endpoints work as they used to.