Skip to content

test: improve auth test coverage #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 29, 2025

Conversation

jescalada
Copy link
Contributor

Builds on top of #963, to improve test coverage for auth methods.

Copy link

netlify bot commented May 23, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 5f04f33
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68611159b7429000086d0113

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (1d30ab5) to head (5f04f33).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/service/passport/activeDirectory.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   71.12%   73.22%   +2.10%     
==========================================
  Files          55       55              
  Lines        2244     2241       -3     
  Branches      249      249              
==========================================
+ Hits         1596     1641      +45     
+ Misses        618      570      -48     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jescalada added 4 commits May 23, 2025 12:42
The getUser function on git-push.js (which used the api/auth/success endpoint) was exported but not used anywhere else
@jescalada jescalada marked this pull request as ready for review May 26, 2025 14:59
@JamieSlome
Copy link
Member

@jescalada - can you look at the merge conflict here? This was a change by @06kellyjac I believe 🤝

@JamieSlome JamieSlome requested a review from 06kellyjac June 17, 2025 12:17
jescalada and others added 2 commits June 19, 2025 03:32
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@jescalada
Copy link
Contributor Author

@JamieSlome This should be ready to go! Just had a minor issue with a test failing due to changes in error handling in the AD auth file.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome enabled auto-merge June 29, 2025 10:12
@JamieSlome JamieSlome merged commit 60bfa32 into finos:main Jun 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing]: Improve test coverage for OIDC and authentication changes
2 participants