-
Notifications
You must be signed in to change notification settings - Fork 138
test: improve auth test coverage #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 71.12% 73.22% +2.10%
==========================================
Files 55 55
Lines 2244 2241 -3
Branches 249 249
==========================================
+ Hits 1596 1641 +45
+ Misses 618 570 -48
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The getUser function on git-push.js (which used the api/auth/success endpoint) was exported but not used anywhere else
@jescalada - can you look at the merge conflict here? This was a change by @06kellyjac I believe 🤝 |
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@JamieSlome This should be ready to go! Just had a minor issue with a test failing due to changes in error handling in the AD auth file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Builds on top of #963, to improve test coverage for auth methods.