Drop visitorId check and refactor functional tests #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream deprecation noise is fixed, so the `E_DEPRECATED` mask and comments are removed from `run_checks.php`. No behavior change. Related-Task: INTER-1473
Remove `visitorId` comparison to avoid false positives. Compare only `requestId`. Add strict types, env function helper, and match for region selection. Normalize variable names. Related-Task: INTER-1473
Use `STDOUT` instead of `STDERR` for writing "Old events are good" message. Related-Task: INTER-1473
|
🟢 Coverage increased by 35.92% Code Coverage ReportCoverage Report
Files Coverage
|
erayaydin
requested review from
Orkuncakilkaya,
TheUnderScorer and
ilfa
as code owners
pnpm exec changesetto create a changeset. |
TheUnderScorer
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the functional test script simpler. We no longer compare
visitorIdbetween recent and oldest events.✏️ What Changed?
requestIdonly (removedvisitorIdcheck) so repeated visitors don't fail the check.declare(strict_types=1).env().match()for region selection.