chore: fix generator script for dev versions #167
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🟢 Coverage increased by 35.52% Code Coverage ReportCoverage Report
Files Coverage
|
TheUnderScorer
previously approved these changes
May 6, 2025
pnpm exec changesetto create a changeset. |
TheUnderScorer
approved these changes
May 6, 2025
erayaydin
requested changes
May 6, 2025
| VERSION="${_temp_part//-/.}-dev" | ||
| elif [[ $VERSION == *-dev* ]]; then | ||
| _temp_part=${VERSION#*-dev} | ||
| _temp_part=${_temp_part//-/.} |
There was a problem hiding this comment.
For stability to be recognized as dev, the version needs to follow the SemVer spec like X.Y.Z-dev+M. You can use this regex and the snippet below to test this.
<?php
use Composer\Semver\VersionParser;
include "../vendor/autoload.php";
var_dump(VersionParser::parseStability("6.5.0-dev.0")); // "stable"
var_dump(VersionParser::parseStability("6.5.0-dev+0")); // "dev"I also suggest using -alpha, -beta, or -rc, since -dev and dev- have special meanings in Composer. Then we can use 6.5.0-rc and 6.5.0-rc.1
ilfa
reviewed
May 7, 2025
| VERSION="dev-$SANITIZED_VERSION-$BUILD_VERSION" | ||
| VERSION=${VERSION//develop/dev} | ||
|
|
||
| if [[ $VERSION =~ ^dev[.-]([0-9]+)[.-]([0-9]+)[.-]([0-9]+)[.-]([0-9]+)$ ]]; then |
There was a problem hiding this comment.
Please add comments with the examples for each case so as not to spend time on this next time when we need to edit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.