Skip to content

Update tests and documentation to use optional params as named params #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

ilfa
Copy link
Member

@ilfa ilfa commented Mar 10, 2025

PHP supports named arguments starting from v8.0.0.

Documentation and examples using optional arguments as named instead of positional will provide better DX to our customers.

@ilfa ilfa force-pushed the update-documentation-INTER-1160 branch from 686223b to 10fb157 Compare March 10, 2025 18:01
@ilfa ilfa force-pushed the update-documentation-INTER-1160 branch from 10fb157 to fe0ce8f Compare March 10, 2025 18:01
Copy link
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

Copy link
Contributor

🟢 Coverage increased by 35.35%

Code Coverage Report

Coverage Report

St. Category Percentage Covered / Total
🔴 Statements 35.35% 1580 / 4469
🔴 Functions 29.79% 638 / 2142
Files Coverage
St. File Methods Statements Total Coverage
🔴 src/Model/BotdBotResult.php 0.00% 0.00% 0.00%
🔴 src/Model/ErrorCode.php 0.00% 0.00% 0.00%
🔴 src/Model/ModelInterface.php 0.00% 0.00% 0.00%
🔴 src/Model/VPNConfidence.php 0.00% 0.00% 0.00%

Copy link
Contributor

@erayaydin erayaydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@ilfa ilfa merged commit 65c8415 into main Mar 14, 2025
15 checks passed
@ilfa ilfa deleted the update-documentation-INTER-1160 branch March 14, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants