Skip to content

breaking: upgrade deps #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2025
Merged

breaking: upgrade deps #90

merged 3 commits into from
Mar 30, 2025

Conversation

emberian
Copy link
Contributor

@emberian emberian commented Mar 20, 2025 •
edited
Loading

upgrades thiserror to 2, and opencl3 to 0.11

increases MSRV to 1.81 (due to the home crate)

Closes #75

vmx
vmx reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the CI. New Rust versions often introduce new lints that need fixes. Can you please have a look?

@emberian
Copy link
Contributor Author

@vmx i have addressed the new clippy errors

vmx
vmx reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one comment inline and it also needs a run of cargo fmt, but then it looks good. Thanks for the changes!

@vmx vmx mentioned this pull request Mar 25, 2025
Closed
@emberian
Copy link
Contributor Author

@vmx done!

@emberian emberian mentioned this pull request Mar 28, 2025
Open
vmx
vmx approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@vmx vmx merged commit ccb3c7e into filecoin-project:master Mar 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmx vmx vmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emberian @vmx