Skip to content

Conversation

@archilex
Copy link
Contributor

Description

When using optgroups with selects the headers look too much like clickable options causing confusion for users. This PR uses darker text to indicate they are not clickabled, but also semibold to indicate it's not just a disabled option.

.fi-dropdown-header was targeted from the select.css class instead of directly inheader.css because .fi-dropdown-header is also used for the dropdown blade component and those styles shouldn't be affected.

Visual changes

Screenshot 2025-10-31 at 12 27 19 PM Screenshot 2025-10-31 at 12 26 51 PM

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Oct 31, 2025
@danharrin danharrin added the enhancement New feature or request label Nov 2, 2025
@danharrin danharrin added this to the v4 milestone Nov 2, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Nov 2, 2025
Signed-off-by: Dan Harrin <git@danharrin.com>
@danharrin danharrin merged commit ace827d into filamentphp:4.x Nov 2, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants