Skip to content

Conversation

@thewtex
Copy link
Collaborator

@thewtex thewtex commented Oct 27, 2025

Functionality required for test_multiscales_metadata_test.ts

Functionality required for test_multiscales_metadata_test.ts
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the initial toMultiscales functionality for TypeScript, adding support for metadata tracking of downsampling methods in the OME-Zarr specification. The implementation provides a simplified version focused on metadata handling rather than actual downsampling operations.

Key changes:

  • Addition of MethodMetadata interface and schema to track downsampling method information (description, package, version)
  • Implementation of toNgffImage and toMultiscales functions for creating NgffImage and Multiscales objects
  • Integration of method metadata into the zarr serialization pipeline

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ts/test/test_multiscales_metadata_test.ts Comprehensive test suite verifying metadata field population, serialization, and round-trip operations
ts/test/hcs_test.ts Updated import statement to use short-form @std/assert
ts/src/utils/method_metadata.ts New utility for generating method metadata based on downsampling method type
ts/src/types/zarr_metadata.ts Added MethodMetadata interface and optional metadata/type fields to Metadata interface
ts/src/schemas/zarr_metadata.ts Added Zod schema validation for MethodMetadata and updated MetadataSchema
ts/src/mod.ts Exported new utility functions and types
ts/src/io/to_ngff_zarr.ts Updated to serialize optional metadata and type fields to zarr attributes
ts/src/io/to_multiscales.ts New implementation of toNgffImage and toMultiscales functions

@thewtex thewtex merged commit 6f6cb00 into main Oct 28, 2025
61 of 62 checks passed
@thewtex thewtex deleted the ts-multiscales branch October 28, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants