Skip to content

Conversation

@thewtex
Copy link
Collaborator

@thewtex thewtex commented Apr 4, 2025

  • COMP: Update pixi.lock
  • ENH: Zarr-Python sharding

thewtex added 2 commits April 3, 2025 15:32
For pixi 0.44.0.
Specified with the chunks_per_shard kwarg to to_ngff_zarr.
@thewtex thewtex mentioned this pull request Apr 4, 2025
@thewtex
Copy link
Collaborator Author

thewtex commented Apr 4, 2025

xref #116

@thewtex thewtex requested a review from Copilot April 4, 2025 17:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

thewtex and others added 2 commits April 4, 2025 13:40
Using the append() method returns None, which results in sharding_kwargs['codecs'] being set to None instead of a list containing the new codec. Consider replacing this with 'previous_codecs + [sharding_codec]' or appending to previous_codecs and then assigning it directly.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@thewtex thewtex merged commit 332511d into main Apr 4, 2025
36 checks passed
@thewtex thewtex deleted the zarr-python-sharding branch April 4, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants